IOS-7733 Tron multiple signing #812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tureck1y
commented
Aug 24, 2024
| .sign(hash: input.hash, walletPublicKey: manager.wallet.publicKey) | ||
| .tryMap { signature in | ||
| try manager.txBuilder.buildForSend(rawData: input.rawData, signature: signature) | ||
| func sendStakeKit(transactions: [StakeKitTransaction], signer: TransactionSigner) -> AnyPublisher<[TransactionSendResult], SendTxError> { |
There was a problem hiding this comment.
пришлось бить на паблишеры, компиллятор не справлялся
skibinalexander
previously approved these changes
Aug 26, 2024
Balashov152
reviewed
Aug 26, 2024
Comment on lines
309
to
310
| guard broadcastResponses.allSatisfy({ $0.result == true }) else { | ||
| throw WalletError.failedToSendTx |
There was a problem hiding this comment.
можно так
Suggested change
| guard broadcastResponses.allSatisfy({ $0.result == true }) else { | |
| throw WalletError.failedToSendTx | |
| guard broadcastResponses.allSatisfy({ $0.result }) else { | |
| throw WalletError.failedToSendTx |
А вообще allSatisfy хитрый, и если broadcastResponses.isEmpty == true то но тоже будет true
можно как вариант добавить )
Andoran90
previously approved these changes
Aug 26, 2024
dbaturin
previously approved these changes
Aug 26, 2024
tureck1y
dismissed stale reviews from dbaturin, Andoran90, and skibinalexander
via
7c10774
tureck1y
added a commit
that referenced
this pull request
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Добавлена поддержка отправки нескольких транзакций одновременно.
Нужно будет тестировать уже на живых данных, я не проверял