IOS-7779 Add TransactionBuilder #817
Conversation
Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
amuraveinik
requested review from
tureck1y,
dbaturin and
a team
as code owners
amuraveinik
requested review from
skibinalexander and
Balashov152
and removed request for
a team
amuraveinik
changed the title
|
|
||
| func buildForSign(transaction: Transaction, nonce: UInt64) throws -> Data { | ||
| guard let feeParameters = transaction.fee.parameters as? FilecoinFeeParameters else { | ||
| throw WalletError.failedToBuildTx |
There was a problem hiding this comment.
Прикольно еще было бы поменять FilecoinTransactionBuilderError.filecoinFeeParametersNotFound что бы если что проще искать было, в чем проблема, а то WalletError.failedToBuildTx много где используется
| throw WalletError.failedToBuildTx | ||
| } | ||
|
|
||
| return try JSONDecoder().decode(FilecoinSignedTransactionBody.self, from: jsonData) |
There was a problem hiding this comment.
А там в API прям json будет уходить? обычно просто длинная hex строка
There was a problem hiding this comment.
| feeParameters: FilecoinFeeParameters | ||
| ) throws -> FilecoinSigningInput { | ||
| guard let value = transaction.amount.bigUIntValue else { | ||
| throw WalletError.failedToBuildTx |
There was a problem hiding this comment.
и тут тоже, ну во всех местах лучше бы FilecoinTransactionBuilderError юзать)
amuraveinik
dismissed
siblockchaina’s stale review
The base branch was changed.
| struct FilecoinFeeParameters: FeeParameters { | ||
| let gasUnitPrice: BigUInt | ||
| let gasLimit: Int64 | ||
| let gasPremium: BigUInt |
There was a problem hiding this comment.
По поводу типов данных - я провалидирую корректность в следующем PRе (про WalletManager)
|
@tureck1y @skibinalexander Влить бы задачку. |
| input.gasLimit = feeParameters.gasLimit | ||
| input.gasPremium = feeParameters.gasPremium.serialize() | ||
|
|
||
| input.publicKey = try Secp256k1Key(with: wallet.publicKey.blockchainKey).decompress() |
There was a problem hiding this comment.
Лучше декомпресснуть один раз и положить в параметры класса
There was a problem hiding this comment.
Пофиксил в следующем PR
#818 (comment)
BlockchainSdk/Blockchains/Filecoin/Network/DTO/FilecoinSignedTransactionBody.swift
Show resolved
Hide resolved
| import XCTest | ||
| @testable import BlockchainSdk | ||
|
|
||
| final class FilecoinTransactionBuilderTests: XCTestCase { |
There was a problem hiding this comment.
не увидел теста на размер транзакции, хоть и секп все равно его надо делать
There was a problem hiding this comment.
Пофиксил в следующем PR
#818 (comment)
|
@siblockchaina Поставь повторно пожалуйста аппрув, слетел после допушиваний |
amuraveinik
deleted the
feature/IOS-7718_filecoin_transaction_builder
branch
IOS-7779