IOS-7619 [Staking] MATIC token in Ethereum #853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Balashov152
commented
Sep 26, 2024
BlockchainSdk/Blockchains/Ethereum/EthereumTransactionBuilder.swift
Outdated
Show resolved
Hide resolved
Balashov152
requested review from
tureck1y,
dbaturin and
a team
as code owners
tureck1y
requested changes
Sep 26, 2024
BlockchainSdk/Blockchains/Ethereum/EthereumTransactionBuilder.swift
Outdated
Show resolved
Hide resolved
BlockchainSdk/Blockchains/Ethereum/EthereumStakeKitTransactionHelper.swift
Show resolved
Hide resolved
BlockchainSdk/Blockchains/Ethereum/EthereumStakeKitTransactionHelper.swift
Show resolved
Hide resolved
BlockchainSdk/Blockchains/Ethereum/EthereumStakeKitTransactionHelper.swift
Outdated
Show resolved
Hide resolved
BlockchainSdk/Blockchains/Ethereum/EthereumTransactionBuilder.swift
Outdated
Show resolved
Hide resolved
Metalicia
approved these changes
Sep 29, 2024
tureck1y
reviewed
Oct 3, 2024
| @@ -78,19 +83,28 @@ class EthereumTransactionBuilder { | |||
| return method.data | |||
| } | |||
|
|
|||
| func buildSigningInput(destination: DestinationType, fee: Fee, parameters: EthereumTransactionParams) throws -> EthereumSigningInput { | |||
| guard let nonce = parameters.nonce, nonce >= 0 else { | |||
| func buildSigningInput(destination: String, coinAmount: BigUInt, fee: Fee, nonce: Int?, data: Data?) throws -> EthereumSigningInput { | |||
There was a problem hiding this comment.
так а нонс не нужен тут опциональный
| @@ -209,35 +194,38 @@ private extension EthereumTransactionBuilder { | |||
| throw EthereumTransactionBuilderError.invalidAmount | |||
| } | |||
|
|
|||
| let parameters = transaction.params as? EthereumTransactionParams ?? .empty | |||
There was a problem hiding this comment.
лучше оставить как было throw EthereumTransactionBuilderError.feeParametersNotFound
There was a problem hiding this comment.
Тут не сосем feeParametersNotFound по этому добавил еще один тип ошибки
| @@ -209,35 +194,38 @@ private extension EthereumTransactionBuilder { | |||
| throw EthereumTransactionBuilderError.invalidAmount | |||
| } | |||
|
|
|||
| let parameters = transaction.params as? EthereumTransactionParams ?? .empty | |||
| let nonce = parameters.nonce | |||
There was a problem hiding this comment.
а нонс тут развернуть тогда тоже
Balashov152
force-pushed
the
feature/IOS-7619-MATIC-Staking
branch
from
8743688
to
48d08ad
Compare
Balashov152
commented
Oct 4, 2024
| @@ -22,8 +22,4 @@ extension EthereumTransactionParams { | |||
| func with(nonce: Int) -> EthereumTransactionParams { | |||
| EthereumTransactionParams(data: data, nonce: nonce) | |||
| } | |||
|
|
|||
| static var empty: EthereumTransactionParams { | |||
There was a problem hiding this comment.
Не используется, да и не нужны такие пустые параметры
tureck1y
approved these changes
Oct 4, 2024
1 task
fedorov-d
approved these changes
Oct 4, 2024
Andoran90
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Проверил