Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IOS-7652 Load images during onboarding #3705

Merged
merged 6 commits into from
Aug 27, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Podfile
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ use_frameworks!
inhibit_all_warnings!

def tangem_sdk_pod
pod 'TangemSdk', :git => 'https://github.com/Tangem/tangem-sdk-ios.git', :tag => 'develop-302'
pod 'TangemSdk', :git => 'https://github.com/Tangem/tangem-sdk-ios.git', :tag => 'develop-305'
#pod 'TangemSdk', :path => '../tangem-sdk-ios'
end

Expand Down
8 changes: 4 additions & 4 deletions Podfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,7 @@ DEPENDENCIES:
- Moya
- Solana.Swift (from `https://github.com/tangem/Solana.Swift`, tag `1.2.0-tangem11`)
- SwiftyJSON (from `https://github.com/tangem/SwiftyJSON.git`, tag `5.0.1-tangem1`)
- TangemSdk (from `https://github.com/Tangem/tangem-sdk-ios.git`, tag `develop-302`)
- TangemSdk (from `https://github.com/Tangem/tangem-sdk-ios.git`, tag `develop-305`)
- WalletConnectSwiftV2 (from `https://github.com/WalletConnect/WalletConnectSwiftV2`, tag `1.18.7`)

SPEC REPOS:
Expand Down Expand Up @@ -287,7 +287,7 @@ EXTERNAL SOURCES:
:tag: 5.0.1-tangem1
TangemSdk:
:git: https://github.com/Tangem/tangem-sdk-ios.git
:tag: develop-302
:tag: develop-305
WalletConnectSwiftV2:
:git: https://github.com/WalletConnect/WalletConnectSwiftV2
:tag: 1.18.7
Expand All @@ -310,7 +310,7 @@ CHECKOUT OPTIONS:
:tag: 5.0.1-tangem1
TangemSdk:
:git: https://github.com/Tangem/tangem-sdk-ios.git
:tag: develop-302
:tag: develop-305
WalletConnectSwiftV2:
:git: https://github.com/WalletConnect/WalletConnectSwiftV2
:tag: 1.18.7
Expand Down Expand Up @@ -354,6 +354,6 @@ SPEC CHECKSUMS:
TangemSdk: 4a188873f9dbed6340cca9ad6a010240af6df432
WalletConnectSwiftV2: 5ea47db4d86e39fc749b66a05a661af9e87b277d

PODFILE CHECKSUM: 39c88afa827f141b4be8ae0e19ec89ead613922e
PODFILE CHECKSUM: 12f86daf305325609ee75b5b41a4192a4d4e5026

COCOAPODS: 1.15.2
37 changes: 19 additions & 18 deletions Tangem/Modules/Onboarding/BaseModels/OnboardingViewModel.swift
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,10 @@ class OnboardingViewModel<Step: OnboardingStep, Coordinator: OnboardingRoutable>
@Published var supplementCardSettings: AnimatedViewSettings = .zero
@Published var isNavBarVisible: Bool = false
@Published var alert: AlertBinder?
@Published var cardImage: Image?
@Published var mainImage: Image?
@Published var customOnboardingImage: Image?
@Published var secondImage: Image?
@Published var thirdImage: Image?

private var confettiFired: Bool = false
var bag: Set<AnyCancellable> = []
Expand Down Expand Up @@ -184,12 +185,7 @@ class OnboardingViewModel<Step: OnboardingStep, Coordinator: OnboardingRoutable>
isFromMain = input.isStandalone
isNavBarVisible = input.isStandalone

let loadImageInput = input.cardInput.imageLoadInput
loadImage(
supportsOnlineImage: loadImageInput.supportsOnlineImage,
cardId: loadImageInput.cardId,
cardPublicKey: loadImageInput.cardPublicKey
)
loadMainImage(imageLoadInput: input.cardInput.imageLoadInput)

bindAnalytics()
}
Expand All @@ -212,20 +208,11 @@ class OnboardingViewModel<Step: OnboardingStep, Coordinator: OnboardingRoutable>
userWalletRepository.add(userWalletModel)
}

func loadImage(supportsOnlineImage: Bool, cardId: String?, cardPublicKey: Data?) {
guard let cardId = cardId, let cardPublicKey = cardPublicKey else {
return
}

func loadImage(supportsOnlineImage: Bool, cardId: String, cardPublicKey: Data) -> AnyPublisher<Image, Never> {
CardImageProvider(supportsOnlineImage: supportsOnlineImage)
.loadImage(cardId: cardId, cardPublicKey: cardPublicKey)
.map { $0.image }
.sink { [weak self] image in
withAnimation {
self?.cardImage = image
}
}
.store(in: &bag)
.eraseToAnyPublisher()
}

func setupContainer(with size: CGSize) {
Expand Down Expand Up @@ -327,6 +314,20 @@ class OnboardingViewModel<Step: OnboardingStep, Coordinator: OnboardingRoutable>
Analytics.log(.onboardingEnableBiometric, params: [.state: Analytics.ParameterValue.toggleState(for: agreed)])
}

private func loadMainImage(imageLoadInput: OnboardingInput.ImageLoadInput) {
loadImage(
supportsOnlineImage: imageLoadInput.supportsOnlineImage,
cardId: imageLoadInput.cardId,
cardPublicKey: imageLoadInput.cardPublicKey
)
.sink { [weak self] image in
withAnimation {
self?.mainImage = image
}
}
.store(in: &bag)
}

private func bindAnalytics() {
$currentStepIndex
.removeDuplicates()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ struct SingleCardOnboardingView: View {
AnimatedView(settings: viewModel.$mainCardSettings) {
OnboardingCardView(
placeholderCardType: .dark,
cardImage: viewModel.cardImage,
cardImage: viewModel.mainImage,
cardScanned: viewModel.isInitialAnimPlayed && viewModel.isCardScanned
)
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -380,7 +380,7 @@ class TwinsOnboardingViewModel: OnboardingTopupViewModel<TwinsOnboardingStep, On
CardImageProvider()
.loadTwinImage(for: twinCardSeries.pair.number)
.map { $0.image }
.zip($cardImage.compactMap { $0 })
.zip($mainImage.compactMap { $0 })
.receive(on: DispatchQueue.main)
.sink { [weak self] paired, main in
guard let self = self else { return }
Expand Down
6 changes: 3 additions & 3 deletions Tangem/Modules/Onboarding/Wallet/WalletOnboardingView.swift
Original file line number Diff line number Diff line change
Expand Up @@ -130,15 +130,15 @@ struct WalletOnboardingView: View {
AnimatedView(settings: viewModel.$thirdCardSettings) {
OnboardingCardView(
placeholderCardType: secondCardPlaceholder,
cardImage: viewModel.secondImage ?? viewModel.cardImage,
cardImage: viewModel.thirdImage,
cardScanned: viewModel.canShowThirdCardImage && (viewModel.backupCardsAddedCount >= 2 || currentStep == .backupIntro) && viewModel.canDisplayCardImage
)
}

AnimatedView(settings: viewModel.$supplementCardSettings) {
OnboardingCardView(
placeholderCardType: secondCardPlaceholder,
cardImage: viewModel.secondImage ?? viewModel.cardImage,
cardImage: viewModel.secondImage,
cardScanned: (viewModel.backupCardsAddedCount >= 1 || currentStep == .backupIntro) && viewModel.canDisplayCardImage
)
}
Expand All @@ -147,7 +147,7 @@ struct WalletOnboardingView: View {
ZStack(alignment: .topTrailing) {
OnboardingCardView(
placeholderCardType: .dark,
cardImage: viewModel.customOnboardingImage ?? viewModel.cardImage,
cardImage: viewModel.customOnboardingImage ?? viewModel.mainImage,
cardScanned: viewModel.isInitialAnimPlayed
)
Text(Localization.commonOriginCard)
Expand Down
65 changes: 49 additions & 16 deletions Tangem/Modules/Onboarding/Wallet/WalletOnboardingViewModel.swift
Original file line number Diff line number Diff line change
Expand Up @@ -329,19 +329,6 @@ class WalletOnboardingViewModel: OnboardingViewModel<WalletOnboardingStep, Onboa
subscribeToScreenshots()
}

private func loadImageForRestoredbackup(cardId: String, cardPublicKey: Data) {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

не использовалось

CardImageProvider()
.loadImage(cardId: cardId, cardPublicKey: cardPublicKey)
.map { $0.image }
.assign(to: \.cardImage, on: self, ownership: .weak)
.store(in: &bag)
}

override func loadImage(supportsOnlineImage: Bool, cardId: String?, cardPublicKey: Data?) {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Честно говоря не сильно понятно, зачем эта перегрузка, может добавляли, когда был дев режим для тестов. Проперти secondImage в целом не юзалось

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

не помню точно, но скорее всего это для первого экрана онбординга, где 2 карточки было, чтобы анимированный переход делать от welcome к онбордингу или что-то такое)

super.loadImage(supportsOnlineImage: supportsOnlineImage, cardId: cardId, cardPublicKey: cardPublicKey)
secondImage = nil
}

override func setupContainer(with size: CGSize) {
stackCalculator.setup(
for: size,
Expand Down Expand Up @@ -691,8 +678,8 @@ class WalletOnboardingViewModel: OnboardingViewModel<WalletOnboardingStep, Onboa
Future { [weak self] promise in
self?.backupService.addBackupCard { result in
switch result {
case .success:
promise(.success(()))
case .success(let card):
promise(.success(card))
case .failure(let error):
promise(.failure(error))
}
Expand All @@ -708,14 +695,32 @@ class WalletOnboardingViewModel: OnboardingViewModel<WalletOnboardingStep, Onboa
self?.isMainButtonBusy = false
}
self?.stepPublisher = nil
}, receiveValue: { [weak self] (_: Void, _: Notification) in
}, receiveValue: { [weak self] card, _ in
self?.loadImage(for: card)
self?.updateStep()
withAnimation {
self?.isMainButtonBusy = false
}
})
}

private func loadImage(for card: Card) {
let input = OnboardingInput.ImageLoadInput(
supportsOnlineImage: true,
cardId: card.cardId,
cardPublicKey: card.cardPublicKey
)

switch backupService.addedBackupCardsCount {
case 1:
loadSecondImage(imageLoadInput: input)
case 2:
loadThirdImage(imageLoadInput: input)
default:
break
}
}

private func backupCard() {
isMainButtonBusy = true

Expand Down Expand Up @@ -835,6 +840,34 @@ class WalletOnboardingViewModel: OnboardingViewModel<WalletOnboardingStep, Onboa
withExtendedLifetime(interactor) {}
}
}

private func loadSecondImage(imageLoadInput: OnboardingInput.ImageLoadInput) {
loadImage(
supportsOnlineImage: imageLoadInput.supportsOnlineImage,
cardId: imageLoadInput.cardId,
cardPublicKey: imageLoadInput.cardPublicKey
)
.sink { [weak self] image in
withAnimation {
self?.secondImage = image
}
}
.store(in: &bag)
}

private func loadThirdImage(imageLoadInput: OnboardingInput.ImageLoadInput) {
loadImage(
supportsOnlineImage: imageLoadInput.supportsOnlineImage,
cardId: imageLoadInput.cardId,
cardPublicKey: imageLoadInput.cardPublicKey
)
.sink { [weak self] image in
withAnimation {
self?.thirdImage = image
}
}
.store(in: &bag)
}
}

// MARK: - Seed phrase related
Expand Down
Loading