IOS-8061 Fix analytics manage tokens #3959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…081_make_fix_analytics_manage_tokens
m3g0byt3
reviewed
Sep 30, 2024
Tangem/Modules/ManageTokens/CustomTokensRelated/AddCustomToken/AddCustomTokenViewModel.swift
Outdated
Show resolved
Hide resolved
Tangem/Modules/ManageTokens/CustomTokensRelated/AddCustomToken/AddCustomTokenViewModel.swift
Outdated
Show resolved
Hide resolved
Tangem/Modules/ManageTokens/CustomTokensRelated/AddCustomToken/AddCustomTokenViewModel.swift
Outdated
Show resolved
Hide resolved
m3g0byt3
approved these changes
Sep 30, 2024
tureck1y
approved these changes
Oct 1, 2024
fedorov-d
reviewed
Oct 2, 2024
|
|
||
| // This subscription is only used to send analytics | ||
| selectedUserWalletModelPublisher | ||
| .dropFirst() |
There was a problem hiding this comment.
а зачем dropFirst?
Это событие нужно только если произошло переключение кошелька, и если не сделать это, то эмитится сразу после открытия экрана, было в подписке выше
fedorov-d
approved these changes
Oct 2, 2024
skibinalexander
deleted the
bugfix/IOS-8081_make_fix_analytics_manage_tokens
branch
tureck1y
pushed a commit
that referenced
this pull request
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Замечания по ивентам привязаны к таске. WIP потому что еще тестирую, были заведены замечания которые не воспроизводятся и улетают нормально