IOS-8131 Recalculate fiat #3976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tureck1y
commented
Sep 30, 2024
| @@ -39,8 +39,7 @@ extension CommonExpressModulesFactory: ExpressModulesFactory { | |||
| let model = ExpressViewModel( | |||
| initialWallet: initialWalletModel, | |||
| userWalletModel: userWalletModel, | |||
| feeFormatter: feeFormatter, | |||
| balanceConverter: balanceConverter, | |||
tureck1y
commented
Sep 30, 2024
| guard roundedAmount != amount else { return } | ||
| guard roundedAmount != amount else { | ||
| // update only fiat in case of another walletModel selection with another quote | ||
| updateSendFiatValue(amount: amount) |
There was a problem hiding this comment.
вот тут не хватало апдейта
There was a problem hiding this comment.
Не знаком с этим кодом совсем, но это не приведет к лишним апдейтам, которые потом триггернут поход в сеть, etc?
skibinalexander
previously approved these changes
Sep 30, 2024
amuraveinik
approved these changes
Sep 30, 2024
m3g0byt3
approved these changes
Sep 30, 2024
| guard roundedAmount != amount else { return } | ||
| guard roundedAmount != amount else { | ||
| // update only fiat in case of another walletModel selection with another quote | ||
| updateSendFiatValue(amount: amount) |
There was a problem hiding this comment.
Не знаком с этим кодом совсем, но это не приведет к лишним апдейтам, которые потом триггернут поход в сеть, etc?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://tangem.atlassian.net/browse/IOS-8131