IOS-8316 [Casper] Make blockchain implementation #4141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s_service' into blockchains/casper/IOS-8316_make_blockchain_implementation # Conflicts: # BlockchainSdk/Blockchains/Casper/Network/CasperTarget.swift # TangemApp.xcodeproj/project.pbxproj
…s_service' into blockchains/casper/IOS-8316_make_blockchain_implementation # Conflicts: # BlockchainSdk/Blockchains/Casper/Network/CasperNetworkProvider.swift # TangemApp.xcworkspace/xcshareddata/swiftpm/Package.resolved
…' into blockchains/casper/IOS-8316_make_blockchain_implementation
…' into blockchains/casper/IOS-8316_make_blockchain_implementation
…' into blockchains/casper/IOS-8316_make_blockchain_implementation
…' into blockchains/casper/IOS-8316_make_blockchain_implementation
…' into blockchains/casper/IOS-8316_make_blockchain_implementation
…' into blockchains/casper/IOS-8316_make_blockchain_implementation # Conflicts: # BlockchainSdk/Blockchains/Casper/Network/CasperNetworkProvider.swift # TangemApp.xcodeproj/project.pbxproj
…' into blockchains/casper/IOS-8316_make_blockchain_implementation # Conflicts: # BlockchainSdk/Common/Blockchain.swift
…' into blockchains/casper/IOS-8316_make_blockchain_implementation
…' into blockchains/casper/IOS-8316_make_blockchain_implementation # Conflicts: # BlockchainSdk/Blockchains/Casper/Network/CasperNetworkProvider.swift # BlockchainSdk/Blockchains/Casper/Network/CasperTarget.swift # TangemApp.xcodeproj/project.pbxproj
skibinalexander
commented
Nov 5, 2024
|
|
||
| /// Why `Localization`? | ||
| /// https://en.wikipedia.org/wiki/Internationalization_and_localization | ||
| internal enum Localization { |
There was a problem hiding this comment.
Что - то лишнее попало уберу ...
There was a problem hiding this comment.
Вообще все это есть в гитигноре вроде как
# Generated
Tangem/Resources/Generated/**.swift
BlockchainSdk/Resources/Generated/**.swift
skibinalexander
requested review from
m3g0byt3 and
Vyachesl0ve
and removed request for
a team
…' into blockchains/casper/IOS-8316_make_blockchain_implementation
…' into blockchains/casper/IOS-8316_make_blockchain_implementation
m3g0byt3
reviewed
Nov 5, 2024
|
|
||
| extension CasperWalletManager { | ||
| enum Constants { | ||
| static let constantFeeValue = Decimal(stringValue: "0.1") |
There was a problem hiding this comment.
Это юзается где-то? Нужна видимость internal?
| // MARK: - Private Implementation | ||
|
|
||
| private func updateWallet(balanceInfo: CasperBalance) { | ||
| if balanceInfo.value != wallet.amounts[.coin]?.value { |
There was a problem hiding this comment.
Опять этот метод убирания пендингов
Получения инфы по хешу транзы опять чтоль нету у этой сетки?
| import Foundation | ||
|
|
||
| extension CasperNetworkResponse { | ||
| /// The balance represented in motes. |
There was a problem hiding this comment.
А что это? Наименьшая атомарная единица?
| encoder.keyEncodingStrategy = .convertToSnakeCase | ||
|
|
||
| return .requestJSONRPC( | ||
| id: Constants.jsonRPCMethodId, |
There was a problem hiding this comment.
id лучше глобально инкрементить (со есть хранить в static var и инкрементить при каждом чтении), чтобы в логах было проще матчить req и resp
|
|
||
| /// Why `Localization`? | ||
| /// https://en.wikipedia.org/wiki/Internationalization_and_localization | ||
| internal enum Localization { |
There was a problem hiding this comment.
Вообще все это есть в гитигноре вроде как
# Generated
Tangem/Resources/Generated/**.swift
BlockchainSdk/Resources/Generated/**.swift
…' into blockchains/casper/IOS-8316_make_blockchain_implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Дополнение реализации каспера. Получение баланса по кошельку
После #4140