Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AND-8236 handle finalized card #407

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

kozarezvlad
Copy link
Collaborator

No description provided.

Comment on lines +244 to +250
val preparingStateCondition =
repo.data.accessCode == null || repo.data.primaryCard == null || repo.data.backupCards.isEmpty()
val finalizingStateCondition =
repo.data.attestSignature == null ||
repo.data.backupData.size < repo.data.backupCards.size ||
repo.data.primaryCardFinalized == false
val finalizingStateConditionWithCount = repo.data.finalizedBackupCardsCount < repo.data.backupCards.size
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Можно is добавить

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

не стал добавлять is, т.к. в конце есть Condition, например isFinalizingState == finalizingStateCondition на мой взгляд

@kozarezvlad kozarezvlad force-pushed the feature/AND-8236-handle-finalized-card branch from 8858bfa to 94f5148 Compare October 2, 2024 08:30
@kozarezvlad kozarezvlad enabled auto-merge (rebase) October 2, 2024 08:30
@kozarezvlad kozarezvlad merged commit 9d6a993 into develop Oct 2, 2024
3 checks passed
@kozarezvlad kozarezvlad deleted the feature/AND-8236-handle-finalized-card branch October 2, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants