IOS-7148 Handle finalized card #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tureck1y
commented
Sep 5, 2024
| } else if repo.data.attestSignature == nil || repo.data.backupData.count < repo.data.backupCards.count { | ||
| } else if repo.data.attestSignature == nil | ||
| || repo.data.backupData.count < repo.data.backupCards.count | ||
| || repo.data.primaryCardFinalized == false { |
There was a problem hiding this comment.
При перезапуске приложения нужно доводить финализацию до конца
amuraveinik
approved these changes
Sep 6, 2024
Andoran90
approved these changes
Sep 10, 2024
m3g0byt3
approved these changes
Sep 10, 2024
Comment on lines
+128
to
+133
| if case .invalidState = error { | ||
| Log.debug("Got \(error). Ignoring..") | ||
| self.onFinalize() | ||
| completion(.success(card)) | ||
| return | ||
| } |
There was a problem hiding this comment.
Получается при invalidState мы все равно помечаем бэкап как выполненный?
There was a problem hiding this comment.
Да, этот invalidState приходит от конкретной команды в кейсе когда она уже выполнилась прежде, поэтому тут безопасно заигнорить его, на карте уже все ок
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Хэндлинг корнер кейсов
https://tangem.atlassian.net/browse/IOS-7148