Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Unused Libraries, Unifying Files Naming and Update README.md Files #1451

Merged
merged 27 commits into from
Jul 20, 2023
Merged

Remove Unused Libraries, Unifying Files Naming and Update README.md Files #1451

merged 27 commits into from
Jul 20, 2023

Conversation

AtelyPham
Copy link
Member

Summary of changes

  • Move code from react-environment library to api-provider-environment and remove react-environment library
  • Move code from fixtures-deployments to browser-utils and remove the fixtures-deployments library
  • Move code form storage to dapp-types and remove the storage library
  • Update the main README.md file add links point to the project README.md files.
  • Add project level README.md files for apps and libs

Proposed area of change

  • apps/bridge-dapp
  • apps/hubble-stats
  • apps/stats-dapp
  • apps/webbsite
  • apps/faucet
  • apps/tangle-website
  • libs/webb-ui-components

Reference issue to close (if applicable)

@AtelyPham AtelyPham added the needs review 👓 Pull request needs a review label Jul 19, 2023
@AtelyPham AtelyPham self-assigned this Jul 19, 2023
@tangle-network tangle-network deleted a comment from github-actions bot Jul 19, 2023
@tangle-network tangle-network deleted a comment from github-actions bot Jul 19, 2023
@tangle-network tangle-network deleted a comment from github-actions bot Jul 19, 2023
@tangle-network tangle-network deleted a comment from github-actions bot Jul 19, 2023
@tangle-network tangle-network deleted a comment from github-actions bot Jul 19, 2023
@tangle-network tangle-network deleted a comment from github-actions bot Jul 19, 2023
@tangle-network tangle-network deleted a comment from github-actions bot Jul 19, 2023
@tangle-network tangle-network deleted a comment from github-actions bot Jul 19, 2023
@tangle-network tangle-network deleted a comment from github-actions bot Jul 19, 2023
@tangle-network tangle-network deleted a comment from github-actions bot Jul 19, 2023
@tangle-network tangle-network deleted a comment from github-actions bot Jul 19, 2023
@tangle-network tangle-network deleted a comment from github-actions bot Jul 19, 2023
@tangle-network tangle-network deleted a comment from github-actions bot Jul 19, 2023
@tangle-network tangle-network deleted a comment from github-actions bot Jul 19, 2023
@tangle-network tangle-network deleted a comment from github-actions bot Jul 19, 2023
@tangle-network tangle-network deleted a comment from github-actions bot Jul 19, 2023
@tangle-network tangle-network deleted a comment from github-actions bot Jul 19, 2023
@tangle-network tangle-network deleted a comment from github-actions bot Jul 19, 2023
@github-actions
Copy link

✅ Deploy Preview for development webbsite is ready! Thanks for the contribution @AtelyPham

Name Link
🔨 Latest commit 63ee7dc494147393047b71a93709d37758452f8c
🔍 Latest deploy log https://app.netlify.com/sites/development-webbsite/deploys/64b80ef78da5312be6bc93b6
😎 Deploy Preview https://64b80ef78da5312be6bc93b6--development-webbsite.netlify.app

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

✅ Deploy Preview for tangle website is ready! Thanks for the contribution @AtelyPham

Name Link
🔨 Latest commit 63ee7dc494147393047b71a93709d37758452f8c
🔍 Latest deploy log https://app.netlify.com/sites/tangle-webbsite/deploys/64b80f1a1eabc8341c290412
😎 Deploy Preview https://64b80f1a1eabc8341c290412--tangle-webbsite.netlify.app

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

✅ Deploy Preview for webb faucet is ready! Thanks for the contribution @AtelyPham

Name Link
🔨 Latest commit 63ee7dc494147393047b71a93709d37758452f8c
🔍 Latest deploy log https://app.netlify.com/sites/webb-faucet/deploys/64b80f1d1eabc834a5290305
😎 Deploy Preview https://64b80f1d1eabc834a5290305--webb-faucet.netlify.app

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

✅ Deploy Preview for webb hubble statistic is ready! Thanks for the contribution @AtelyPham

Name Link
🔨 Latest commit 63ee7dc494147393047b71a93709d37758452f8c
🔍 Latest deploy log https://app.netlify.com/sites/hubble-stats/deploys/64b80f222349e63102dc6c31
😎 Deploy Preview https://64b80f222349e63102dc6c31--hubble-stats.netlify.app

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

✅ Deploy Preview for bridge-dapp development is ready! Thanks for the contribution @AtelyPham

Name Link
🔨 Latest commit 63ee7dc494147393047b71a93709d37758452f8c
🔍 Latest deploy log https://app.netlify.com/sites/development-hubble-bridge/deploys/64b80f6b06e65a3540df8469
😎 Deploy Preview https://64b80f6b06e65a3540df8469--development-hubble-bridge.netlify.app

To edit notification comments on pull requests, go to your Netlify site settings.

vutuanlinh2k2
vutuanlinh2k2 approved these changes Jul 20, 2023
View reviewed changes
Copy link
Contributor

@vutuanlinh2k2 vutuanlinh2k2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@drewstone drewstone merged commit 6c000a5 into develop Jul 20, 2023
@drewstone drewstone deleted the trung-tin/update-readme branch July 20, 2023 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elkremroot elkremroot elkremroot approved these changes

@vutuanlinh2k2 vutuanlinh2k2 vutuanlinh2k2 approved these changes

@drewstone drewstone Awaiting requested review from drewstone

@devpavan04 devpavan04 Awaiting requested review from devpavan04 devpavan04 is a code owner

Assignees

@AtelyPham AtelyPham

Labels
needs review 👓 Pull request needs a review
Projects
Webb Universe
Status: Completed ✅
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[TASK] Improve dApp README
4 participants
@AtelyPham @vutuanlinh2k2 @elkremroot @drewstone