Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Environment Variables Issue #1465

Merged
merged 4 commits into from
Jul 26, 2023
Merged

Conversation

AtelyPham
Copy link
Member

Summary of changes

  • Move all env vars to root environment variable file
  • Prefixed bridge dapp environments variable by (BRIDGE_DAPP_ for scoping the env variables)
  • Load bridge dapp-specific env vars in webpack

Proposed area of change

Put an x in the boxes that apply.

  • apps/bridge-dapp
  • apps/hubble-stats
  • apps/stats-dapp
  • apps/webbsite
  • apps/faucet
  • apps/tangle-website
  • libs/webb-ui-components

Reference issue to close (if applicable)

  • Closes NaN

@AtelyPham AtelyPham added the needs review 👓 Pull request needs a review label Jul 26, 2023
@AtelyPham AtelyPham self-assigned this Jul 26, 2023
Copy link
Contributor

@drewstone drewstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drewstone
Copy link
Contributor

Build failed @AtelyPham

@AtelyPham
Copy link
Member Author

Build failed @AtelyPham

The comment-on-pr GitHub action encountered issues while running on both v1.3.0 and v1.3.1. You can find more details in this issue. I've already addressed this problem in Linh's PR, but this fix only applies to the Hubble Stats DApp. Please extend this fix to all deploy preview apps.

@github-actions
Copy link

Deploy Preview for bridge-dapp development is ready! Thanks for the contribution @AtelyPham

Name Link
🔨 Latest commit 9e0d0e8c527934524a570dff1c4f8af10c54aa4d
🔍 Latest deploy log https://app.netlify.com/sites/development-hubble-bridge/deploys/64c1578c5a7e6628f507dadd
😎 Deploy Preview https://64c1578c5a7e6628f507dadd--development-hubble-bridge.netlify.app

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

Deploy Preview for webb faucet is ready! Thanks for the contribution @AtelyPham

Name Link
🔨 Latest commit 9e0d0e8c527934524a570dff1c4f8af10c54aa4d
🔍 Latest deploy log https://app.netlify.com/sites/webb-faucet/deploys/64c158e3416103255e512ea7
😎 Deploy Preview https://64c158e3416103255e512ea7--webb-faucet.netlify.app

To edit notification comments on pull requests, go to your Netlify site settings.

@AtelyPham AtelyPham merged commit b1678c5 into develop Jul 26, 2023
8 checks passed
@AtelyPham AtelyPham deleted the trung-tin/fix-env-vars-issue branch July 26, 2023 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs review 👓 Pull request needs a review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants