Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Token Approval Issue #1480

Merged
merged 1 commit into from
Aug 1, 2023
Merged

Fix Token Approval Issue #1480

merged 1 commit into from
Aug 1, 2023

Conversation

AtelyPham
Copy link
Member

Summary of changes

  • Fix the token approval issue on the wrap and deposit process

Proposed area of change

Put an x in the boxes that apply.

  • apps/bridge-dapp
  • apps/hubble-stats
  • apps/stats-dapp
  • apps/webbsite
  • apps/faucet
  • apps/tangle-website
  • libs/webb-ui-components

Reference issue to close (if applicable)

Screen Recording

CleanShot.2023-08-01.at.02.50.22.mp4

@AtelyPham AtelyPham added the needs review 👓 Pull request needs a review label Jul 31, 2023
@AtelyPham AtelyPham self-assigned this Jul 31, 2023
@AtelyPham AtelyPham requested a review from drewstone July 31, 2023 19:52
@AtelyPham AtelyPham added the bridge Issues specific to the bridge label Jul 31, 2023
drewstone
drewstone approved these changes Aug 1, 2023
View reviewed changes
Copy link
Contributor

@drewstone drewstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, did you test it @AtelyPham ?

@vutuanlinh2k2
Copy link
Contributor

LGTM!

@AtelyPham
Copy link
Member Author

LG, did you test it @AtelyPham ?

Yes, I've tested it and shared the screen recording in the PR.

@AtelyPham AtelyPham merged commit 06bd9d6 into develop Aug 1, 2023
6 checks passed
@AtelyPham AtelyPham deleted the trung-tin/fix-token-approval branch August 1, 2023 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vutuanlinh2k2 vutuanlinh2k2 vutuanlinh2k2 approved these changes

@drewstone drewstone drewstone approved these changes

@devpavan04 devpavan04 Awaiting requested review from devpavan04 devpavan04 is a code owner

Assignees

@AtelyPham AtelyPham

Labels
bridge Issues specific to the bridge needs review 👓 Pull request needs a review
Projects
Webb Universe
Status: Completed ✅
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Error: ERC20: transfer amount exceeds allowance During Wrap and Deposit
3 participants
@AtelyPham @vutuanlinh2k2 @drewstone