Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hubble Stats dummy data #1499

Merged
merged 25 commits into from
Aug 4, 2023
Merged

Hubble Stats dummy data #1499

merged 25 commits into from
Aug 4, 2023

Conversation

vutuanlinh2k2
Copy link
Contributor

Summary of changes

Provide a detailed description of proposed changes.

  • Add dummy data for Hubble Stats
  • Modify container components to match server component design
  • Minor refactor of some components

Proposed area of change

Put an x in the boxes that apply.

  • apps/bridge-dapp
  • apps/hubble-stats
  • apps/stats-dapp
  • apps/webbsite
  • apps/faucet
  • apps/tangle-website
  • libs/webb-ui-components

Reference issue to close (if applicable)

Specify any issues that can be closed from these changes (e.g. Closes #233).

Screen Recording

If possible provide a screen recording of proposed change.

Screen.Recording.2023-08-04.at.20.26.46.mov

Code Checklist

Please be sure to add .stories documentation if any additions are made to libs/webb-ui-components.

  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@github-actions
Copy link

github-actions bot commented Aug 4, 2023

Deploy Preview for webb hubble statistic is ready! Thanks for the contribution @vutuanlinh2k2

Name Link
🔨 Latest commit 3f0cd02cecbcaeb19189c366a3ff1b31be09d00a
🔍 Latest deploy log https://app.netlify.com/sites/hubble-stats/deploys/64cd01f303c12f0d8c21d638
😎 Deploy Preview https://64cd01f303c12f0d8c21d638--hubble-stats.netlify.app

To edit notification comments on pull requests, go to your Netlify site settings.

@monaiuu
Copy link
Contributor

monaiuu commented Aug 4, 2023

Thanks for the quick update @vutuanlinh2k2! I will use this view as reference to conduct UI audit and propose improvements.

Copy link
Member

@AtelyPham AtelyPham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍!

@AtelyPham AtelyPham merged commit 85ac1bd into develop Aug 4, 2023
7 checks passed
@AtelyPham AtelyPham deleted the linh/hubble-stats-dummy-data branch August 4, 2023 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants