Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2 Transaction Input Card #1548

Merged
merged 6 commits into from
Aug 21, 2023

Conversation

AtelyPham
Copy link
Member

Summary of changes

  • Adding V2 Transaction Input Card
  • Fix the UI issue on the TextField component
  • Modify the placeholder for the TokenSelector

Proposed area of change

Put an x in the boxes that apply.

  • apps/bridge-dapp
  • apps/hubble-stats
  • apps/stats-dapp
  • apps/webbsite
  • apps/faucet
  • apps/tangle-website
  • libs/webb-ui-components

Reference issue to close (if applicable)

Specify any issues that can be closed from these changes (e.g. Closes #233).

Screen Recording

If possible provide a screen recording of proposed change.

CleanShot.2023-08-17.at.04.34.51.mp4

Code Checklist

Please be sure to add .stories documentation if any additions are made to libs/webb-ui-components.

  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@AtelyPham AtelyPham added the needs review 👓 Pull request needs a review label Aug 16, 2023
@AtelyPham AtelyPham requested a review from monaiuu August 16, 2023 21:37
@AtelyPham AtelyPham self-assigned this Aug 16, 2023
Copy link
Contributor

@vutuanlinh2k2 vutuanlinh2k2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😊

@AtelyPham
Copy link
Member Author

The new component Storybook for UI review. cc @monaiuu.

Copy link
Contributor

@monaiuu monaiuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments from me:

  • Remove hover state for amount field
Screenshot 2023-08-17 at 10 26 47 AM
  • Apply hover state to the entire Transaction Input Card by updating background clolor (dark default:2B2F40; hover: 2E3244/ light default: F7F8F7CC (80% opacity); hover: F7F8F7)
    Screenshot 2023-08-17 at 10 45 39 AM

@@ -0,0 +1,337 @@
'use client';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to use use client inwebb-ui-components?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, since some components will be utilized in the Next app, it is beneficial to identify whether a new component is for the server or the client. Additionally, we need to address the task of reviewing the web-ui-kit and labeling which components are server components and which are client components.

@AtelyPham AtelyPham merged commit 7b0f555 into hubble-bridge-v2 Aug 21, 2023
6 checks passed
@AtelyPham AtelyPham deleted the trung-tin/v2-transaction-input-card branch August 21, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs review 👓 Pull request needs a review
Projects
Status: Completed ✅
Development

Successfully merging this pull request may close these issues.

4 participants