-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V2 Transaction Input Card #1548
V2 Transaction Input Card #1548
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 😊
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -0,0 +1,337 @@ | |||
'use client'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to use use client
inwebb-ui-components
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, since some components will be utilized in the Next app, it is beneficial to identify whether a new component is for the server or the client. Additionally, we need to address the task of reviewing the web-ui-kit and labeling which components are server components and which are client components.
Summary of changes
Proposed area of change
Put an
x
in the boxes that apply.apps/bridge-dapp
apps/hubble-stats
apps/stats-dapp
apps/webbsite
apps/faucet
apps/tangle-website
libs/webb-ui-components
Reference issue to close (if applicable)
Specify any issues that can be closed from these changes (e.g. Closes #233).
Transaction Input Card
component #1405Screen Recording
If possible provide a screen recording of proposed change.
CleanShot.2023-08-17.at.04.34.51.mp4
Code Checklist
Please be sure to add .stories documentation if any additions are made to
libs/webb-ui-components
.