Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tangle-dapp): Implement Liquifier unlock NFTs unstake requests table #2521

Merged
merged 68 commits into from
Aug 30, 2024

Conversation

yurixander
Copy link
Member

@yurixander yurixander commented Aug 24, 2024

Summary of changes

Provide a detailed description of proposed changes.

  • ➕ Unstake requests table now lists unlock NFTs for the active EVM user account.
  • ➕ Added ability to withdraw unlock NFTs that have reached maturity.
  • Exchange rate is now shown for EVM liquid staking operations.
  • Fees are now shown for EVM liquid staking operations.
  • ➕ An error state is shown in case that the fees or exchange rate fail to load.
  • 🖌️ Updated the structure of the liquid staking inputs to display the network on top (ie. Ethereum Mainnet or Tangle Restaking Parachain), and the token on the bottom, as suggested by @drewstone. Note that this visual change isn't present in the screen recording video below.
  • ⚠️ Rebond functionality is not available in liquifier as of now, and thus has not been implemented. Only the withdraw action can be performed for unlock NFTs.
  • ⚠️ Currently, the withdraw operation is not batched. This isn't ideal since the user would need to perform a transaction per unlock NFT. I will be implementing that in [TASK] Use Liquifier.sol::multicall to batch withdraw transactions #2522.

Proposed area of change

Put an x in the boxes that apply.

  • apps/bridge-dapp
  • apps/hubble-stats
  • apps/stats-dapp
  • apps/tangle-dapp
  • apps/testnet-leaderboard
  • apps/faucet
  • apps/zk-explorer
  • libs/webb-ui-components

Reference issue to close (if applicable)

Specify any issues that can be closed from these changes (e.g. Closes #233).

Screen Recording

If possible provide a screen recording of proposed change.

withdraw.unstake.requests.mp4

Code Checklist

Please be sure to add .stories documentation if any additions are made to libs/webb-ui-components.

  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@yurixander
Copy link
Member Author

@freeslugs Just to confirm, we don't have a rebond/re-stake NFT functionality in the liquifier contract, just withdraw? 👀

@freeslugs
Copy link

since chainlink only has withdraw, we will only support that at the moment too.

@drewstone drewstone marked this pull request as ready for review August 26, 2024 14:10
@yurixander yurixander marked this pull request as draft August 27, 2024 00:11
@yurixander yurixander marked this pull request as ready for review August 29, 2024 09:07
@drewstone drewstone merged commit a881ede into develop Aug 30, 2024
13 checks passed
@drewstone drewstone deleted the yuri/liquifier-unlock-nfts-table branch August 30, 2024 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tangle-dapp Tangle Staking dApp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] Add unlock NFTs table for EVM-based liquid staking
3 participants