Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tangle-dapp): Implement updated design for LS pools #2570

Merged
merged 65 commits into from
Oct 5, 2024

Conversation

yurixander
Copy link
Member

@yurixander yurixander commented Sep 27, 2024

Summary of changes

Provide a detailed description of proposed changes.

  • ➕ Added a new table which lists LS pools that the user is involved in: either via management roles, or staked in. This provides a quick view on how the pools which you've staked on are performing (APY), and also management actions in case you have management roles.
  • ➕ The action button's text will change depending on the action that the user will take. For example, if the user is about to stake on a pool in which they already have a stake in, it'll show Increase Stake, otherwise Stake.
  • ➕ Added various table states for the LS pool tables: Loading, error, and empty.
  • ➕ Implemented onboarding modal logic, and also onboarding modal for the liquid staking page (see [FEAT] Add onboarding modals for restaking & bridge pages #2577).
  • ➕ Added OpenGraph page metadata to the Liquid Staking page.
  • 🔧 Simplified liquid staking pages: Instead of having an overview page, both liquid staking & overview page will now live in a single page for a more streamlined UX.
  • 🖌️ Adjusted design of the pools table and simplified interaction & pool selection process.
  • ⚠️ Restaking Parachain LS protocol handling hasn't yet been adjusted since there are still changes that need to be made on the parachain, such as associating every pool with a single token (ie. DOT, PHA, etc.). CC @1xstj

Proposed area of change

Put an x in the boxes that apply.

  • apps/bridge-dapp
  • apps/hubble-stats
  • apps/stats-dapp
  • apps/tangle-dapp
  • apps/testnet-leaderboard
  • apps/faucet
  • apps/zk-explorer
  • libs/webb-ui-components

Reference issue to close (if applicable)

Specify any issues that can be closed from these changes (e.g. Closes #233).

Screen Recording

If possible provide a screen recording of proposed change.

liquid-staking-updated-flow.mp4

Screenshot 2024-10-04 at 06 45 50
Screenshot 2024-10-04 at 05 50 54
Screenshot 2024-10-04 at 04 25 43


Code Checklist

Please be sure to add .stories documentation if any additions are made to libs/webb-ui-components.

  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@yurixander
Copy link
Member Author

⚠️ Restaking Parachain LS protocol handling hasn't yet been adjusted since there are still changes that need to be made on the parachain, such as associating every pool with a single token (ie. DOT, PHA, etc.). CC @1xstj

CC @1xstj

@yurixander yurixander marked this pull request as ready for review October 4, 2024 11:53
Copy link
Contributor

@drewstone drewstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, my only nit is that I think we should be making numeric values font size larger. There's a few areas that looks so tiny and my eyes strain looking at them! CC @monaiuu.

@drewstone
Copy link
Contributor

Let's cut a release! @yurixander @AtelyPham

@drewstone drewstone merged commit bbfab3d into develop Oct 5, 2024
11 checks passed
@drewstone drewstone deleted the yuri/ls-pools-impl-new-design branch October 5, 2024 18:39
@yurixander
Copy link
Member Author

Let's cut a release! @yurixander @AtelyPham

Yep. I'll also see if I can get the pool creation flow in today or tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] Update liquid staking design impl. to accomodate LS pools
3 participants