Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: handle properly empty title on Pagination #2607

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

AtelyPham
Copy link
Member

Summary of changes

Provide a detailed description of proposed changes.

  • Handle empty title on Pagination component.

Proposed area of change

Put an x in the boxes that apply.

  • apps/tangle-dapp
  • libs/webb-ui-components

Associated issue(s)

Specify any issues that can be closed from these changes (e.g. Closes #233).

  • Closes NaN

@AtelyPham AtelyPham added the needs review 👓 Pull request needs a review label Oct 28, 2024
@AtelyPham AtelyPham self-assigned this Oct 28, 2024
Copy link

netlify bot commented Oct 28, 2024

Deploy Preview for tangle-dapp ready!

Name Link
🔨 Latest commit ce7ec83
🔍 Latest deploy log https://app.netlify.com/sites/tangle-dapp/deploys/671f794bf65abf0008be5a66
😎 Deploy Preview https://deploy-preview-2607--tangle-dapp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@AtelyPham AtelyPham mentioned this pull request Oct 28, 2024
10 tasks
@AtelyPham AtelyPham merged commit d8e058e into develop Oct 28, 2024
11 checks passed
@AtelyPham AtelyPham deleted the trung-tin/empty-title-pagination branch October 28, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs review 👓 Pull request needs a review
Projects
Status: Completed ✅
Development

Successfully merging this pull request may close these issues.

3 participants