Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Cleanup unused deps & remove legacy dApps #2632

Merged
merged 9 commits into from
Nov 4, 2024

Conversation

yurixander
Copy link
Member

@yurixander yurixander commented Nov 3, 2024

Summary of changes

Provide a detailed description of proposed changes.

  • Removed legacy dApps.
  • Removed unused dependencies.

Proposed area of change

Put an x in the boxes that apply.

  • apps/tangle-dapp
  • apps/tangle-cloud
  • libs/webb-ui-components

Associated issue(s)

Specify any issues that can be closed from these changes (e.g. Closes #233).

Screen Recording

If possible provide screenshots and/or a screen recording of proposed change.


@yurixander yurixander self-assigned this Nov 3, 2024
Copy link

netlify bot commented Nov 3, 2024

Deploy Preview for tangle-cloud ready!

Name Link
🔨 Latest commit 3d2f2ee
🔍 Latest deploy log https://app.netlify.com/sites/tangle-cloud/deploys/6727b672f4b1c8000832fa48
😎 Deploy Preview https://deploy-preview-2632--tangle-cloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 3, 2024

Deploy Preview for tangle-dapp ready!

Name Link
🔨 Latest commit 3d2f2ee
🔍 Latest deploy log https://app.netlify.com/sites/tangle-dapp/deploys/6727b672362b69000812fd8a
😎 Deploy Preview https://deploy-preview-2632--tangle-dapp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@yurixander
Copy link
Member Author

I suspect this one might likely break something given the amount of deps removed, even though the build passes. Let me know if you guys notice anything weird after it's merged @devpavan04 @AtelyPham

@yurixander yurixander marked this pull request as ready for review November 3, 2024 17:50
@drewstone drewstone merged commit 5a7aa61 into develop Nov 4, 2024
18 checks passed
@drewstone drewstone deleted the yuri/cleanup-deps branch November 4, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TASK] Remove legacy dApps & unused/redundant dependencies
2 participants