Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update to latest changes in tangle #367

Merged
merged 6 commits into from
Oct 22, 2024
Merged

Conversation

shekohex
Copy link
Contributor

@shekohex shekohex commented Oct 21, 2024

This pull request includes several updates across multiple files, focusing on dependency updates, code refactoring, and metadata extraction improvements. The most important changes include upgrading dependencies, refactoring hooks and job extraction logic, and introducing new metadata extraction functions.

Mainly, the new changes we are introducing in the tangle-network/tangle#794 removes the notion of separate hooks and instead unifies everything in one filed called manager in the Service Blueprint. This field will be set to the EVM Smart contract that manages the lifecycle of a the blueprint instances.

# Cargo.toml

[package.metadata.blueprint]
manager = { evm = "IncredibleSquaringBlueprint" }

No more #[job(verifier(evm = "IncredibleSquaringBlueprint"))] on top of each job. This manager has a onJobResult and onJobCall hooks where you can do your normal validation and verification if you want. (by default they are no_op)

Dependency Updates:

Code Refactoring:

Metadata Extraction:

Submodule Updates:

@shekohex shekohex marked this pull request as ready for review October 22, 2024 12:57
Copy link
Contributor

@drewstone drewstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the comment, this looks good.

blueprint-metadata/src/lib.rs Outdated Show resolved Hide resolved
@shekohex shekohex merged commit 2274dd0 into main Oct 22, 2024
11 checks passed
@shekohex shekohex deleted the shady/slashing-updates branch October 22, 2024 15:40
This was referenced Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants