Update to polkadot-v1.0.0 #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 3, 2023
shekohex
requested changes
Aug 3, 2023
shekohex
approved these changes
Aug 3, 2023
|
@1xstj could you also please change the CI for formatting to use rust nightly toolchain instead of the stable one? since we ignore all the generated files from the formatting |
not sure I follow, the CI failure is becuase we dont format the files in /contracts/protocol-solidity, how will nightly/stable change this? 🤔 Will followup in another PR so that the other PRs depending on this is not blocked |
|
Ran cargo fmt again, cannot merge PR without all checks being green |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.