Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved cmake build to build without to checkout "external/json" manually #5

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Bjoe
Copy link
Contributor

@Bjoe Bjoe commented Apr 20, 2021

This PR will fix the problem, if you would like to build these project against an already installed JSON "lib"/header.
Also I implemented a solution to "fetch" the sources without to fetch the sources "manually" into external/json

@codecov-commenter
Copy link

codecov-commenter commented Apr 20, 2021

Codecov Report

Merging #5 (c11299d) into master (341b6ce) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #5      +/-   ##
==========================================
+ Coverage   64.96%   64.97%   +0.01%     
==========================================
  Files         107      107              
  Lines        2189     2187       -2     
==========================================
- Hits         1422     1421       -1     
+ Misses        767      766       -1     
Impacted Files Coverage Δ
include/tao/config/schema/internal/grammar.hpp 34.48% <0.00%> (-0.35%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 341b6ce...c11299d. Read the comment docs.

@ColinH ColinH requested a review from d-frey April 20, 2021 16:27
@Bjoe
Copy link
Contributor Author

Bjoe commented Apr 20, 2021

Unfortunately there is following in your JSON (also PEGTL) project:

In the JSON project you "alias" the JSON target from taocpp-json to ``taocpp::json. But when you "install" the lib/header and provide the cmake config-modul, the target is exported as taocpp::taocpp-json` because when you "export" the project it will be exported with the given namespace from `install(EXPORT ..... NAMESPACE ....)` in your solution it is `taocpp::` plus the target name, in your solution `taocpp-json`. The result is `taocpp::taocpp-json`

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants