Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

api: add support of a batch insert request #411

Merged
merged 4 commits into from
Oct 11, 2024
Merged

api: add support of a batch insert request #411

merged 4 commits into from
Oct 11, 2024

Conversation

dmyger
Copy link

@dmyger dmyger commented Oct 2, 2024

Draft changes: add support the IPROTO_INSERT_ARROW request and message pack type MP_ARROW .

Closes #399

@dmyger dmyger added the feature A new functionality label Oct 2, 2024
@oleg-jukovec oleg-jukovec removed the feature A new functionality label Oct 2, 2024
@dmyger dmyger force-pushed the dmyger/gh-399-add-support-IPROTO_INSERT_ARROW branch 11 times, most recently from 1f88b6f to b6ad2cc Compare October 7, 2024 15:46
@dmyger dmyger marked this pull request as ready for review October 7, 2024 15:47
@dmyger dmyger requested a review from DerekBum October 7, 2024 15:48
oleg-jukovec
oleg-jukovec reviewed Oct 7, 2024
View reviewed changes
arrow/arrow.go Outdated Show resolved Hide resolved
test_helpers/main.go Outdated Show resolved Hide resolved
test_helpers/main.go Show resolved Hide resolved
arrow/arrow.go Outdated Show resolved Hide resolved
arrow/arrow.go Outdated Show resolved Hide resolved
arrow/example_test.go Outdated Show resolved Hide resolved
arrow/example_test.go Outdated Show resolved Hide resolved
arrow/example_test.go Outdated Show resolved Hide resolved
request_test.go Outdated Show resolved Hide resolved
arrow/arrow.go Show resolved Hide resolved
@oleg-jukovec
Copy link
Collaborator

Draft changes: add support the IPROTO_INSERT_ARROW request and message pack type MP_ARROW . Please, split the commit message into multiple lines. A commit message should contains lines with 72 chars max.

oleg-jukovec
oleg-jukovec reviewed Oct 8, 2024
View reviewed changes
arrow/request.go Outdated Show resolved Hide resolved
@dmyger
ci: update lint rule for long lines
44ff22e
@dmyger
test: Allow use environment variable TARANTOOL_BIN
59aa1a3 
Environment variable TARANTOOL_BIN can be used to
specify path of Tarantool executable.
@dmyger dmyger force-pushed the dmyger/gh-399-add-support-IPROTO_INSERT_ARROW branch from b6ad2cc to d7e9eab Compare October 8, 2024 14:19
oleg-jukovec
oleg-jukovec requested changes Oct 8, 2024
View reviewed changes
Copy link
Collaborator

@oleg-jukovec oleg-jukovec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great to see green tests first.

@dmyger dmyger force-pushed the dmyger/gh-399-add-support-IPROTO_INSERT_ARROW branch 3 times, most recently from a994eb0 to 53310a5 Compare October 9, 2024 10:04
oleg-jukovec
oleg-jukovec approved these changes Oct 9, 2024
View reviewed changes
Copy link
Collaborator

@oleg-jukovec oleg-jukovec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the patch. Just a few non-critical issues left.

arrow/arrow_test.go Show resolved Hide resolved
arrow/config-ee.lua Outdated Show resolved Hide resolved
arrow/example_test.go Outdated Show resolved Hide resolved
arrow/request.go Outdated Show resolved Hide resolved
arrow/request_test.go Outdated Show resolved Hide resolved
arrow/request_test.go Outdated Show resolved Hide resolved
@dmyger dmyger force-pushed the dmyger/gh-399-add-support-IPROTO_INSERT_ARROW branch from 53310a5 to 7d49fd0 Compare October 10, 2024 14:14
oleg-jukovec
oleg-jukovec approved these changes Oct 10, 2024
View reviewed changes
Copy link
Collaborator

@oleg-jukovec oleg-jukovec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

DerekBum
DerekBum reviewed Oct 10, 2024
View reviewed changes
arrow/config-memcs.lua Outdated Show resolved Hide resolved
arrow/config-memcs.lua Outdated Show resolved Hide resolved
@dmyger
api: add support of a batch insert request
b917d6f 
Add support the IPROTO_INSERT_ARROW request and
message pack type MP_ARROW.

Closes #399
@dmyger dmyger force-pushed the dmyger/gh-399-add-support-IPROTO_INSERT_ARROW branch from 7d49fd0 to b917d6f Compare October 11, 2024 09:32
@oleg-jukovec oleg-jukovec merged commit d4b5d04 into master Oct 11, 2024
26 checks passed
@oleg-jukovec oleg-jukovec deleted the dmyger/gh-399-add-support-IPROTO_INSERT_ARROW branch October 11, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DerekBum DerekBum DerekBum approved these changes

@oleg-jukovec oleg-jukovec oleg-jukovec approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

api: add support of a batch insert request
3 participants
@dmyger @oleg-jukovec @DerekBum