Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move to sops for prod secrets #790

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

move to sops for prod secrets #790

wants to merge 2 commits into from
+198 −1

Conversation

tarasglek
Copy link
Owner

@tarasglek tarasglek commented Jan 20, 2025 •
edited
Loading

per #769
Need to figure out how to get past

✘ [ERROR] Expected ";" but found "with"

    functions/secrets.ts:2:46:
      2 │ import production_json from "production.json" with { type: "json" };

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Jan 20, 2025 •
edited
Loading

Deploying chatcraft-org with  Cloudflare Pages  Cloudflare Pages

Latest commit: 93a69ad
Status: ✅  Deploy successful!
Preview URL: https://ed265b70.console-overthinker-dev.pages.dev
Branch Preview URL: https://taras-sops.console-overthinker-dev.pages.dev

View logs

@tarasglek
Copy link
Owner Author

tarasglek commented Jan 20, 2025 •
edited
Loading

I don't understand, cos "resolveJsonModule": true is set in tsconfig. @humphd help pls

@humphd
Copy link
Collaborator

humphd commented Jan 20, 2025

My guess is that you have to tell wrangler about this, see https://developers.cloudflare.com/workers/wrangler/configuration/#bundling

@humphd
Copy link
Collaborator

humphd commented Jan 20, 2025 •
edited
Loading

I guess wrangler doesn't support JSON modules?

https://developers.cloudflare.com/workers/wrangler/bundling/

humphd
humphd reviewed Jan 21, 2025
View reviewed changes
Copy link
Collaborator

@humphd humphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat. One small thing, looks good otherwise.

functions/secrets.ts
secretKey: AGE_SECRET_KEY,
});
}
throw new Error("Unknown environmentp");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@humphd humphd humphd left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tarasglek @humphd