Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new file parser option for non-homologous expansion #2375

Closed
wants to merge 15 commits into from

Conversation

ymatsumu
Copy link
Contributor

📝 Description

Type: 🚀 feature

A step to enable non-homologous expansion by reading and parsing a .csv file with radius.

📌 Resources

Examples, notebooks, and links to useful references.

🚦 Testing

How did you test these changes?

  • Testing pipeline
  • Other method (describe)
  • My changes can't be tested (explain why)

☑️ Checklist

  • I requested two reviewers for this pull request
  • I updated the documentation according to my changes
  • I built the documentation by applying the build_docs label

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Merging #2375 (880d249) into master (5b36105) will decrease coverage by 0.04%.
The diff coverage is 20.00%.

❗ Current head 880d249 differs from pull request most recent head 03ced67. Consider uploading reports for the commit 03ced67 to get more accurate results

@@            Coverage Diff             @@
##           master    #2375      +/-   ##
==========================================
- Coverage   70.57%   70.53%   -0.04%     
==========================================
  Files         139      139              
  Lines       12875    12885      +10     
==========================================
+ Hits         9087     9089       +2     
- Misses       3788     3796       +8     
Files Changed Coverage Δ
.../montecarlo/montecarlo_numba/nonhomologous_grid.py 48.00% <ø> (ø)
tardis/io/model_reader.py 64.50% <11.11%> (-1.70%) ⬇️
tardis/montecarlo/montecarlo_configuration.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@andrewfullard
Copy link
Contributor

Would it be possible to add a test to this?

@andrewfullard
Copy link
Contributor

This seems to be the basis for PR 2380, is that correct?

@wkerzendorf
Copy link
Member

stale PR - closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants