Merge branch 'master' into migrate-to-mailpit

.github/workflows/labeler.yml

@@ -1,7 +1,6 @@
 name: labeler
-
 on:
-  pull_request:
+  pull_request_target:
     types: ['opened', 'ready_for_review', 'reopened', 'synchronize']
 
 jobs:
@@ -14,11 +13,18 @@ jobs:
     name: Label the PR size
     steps:
       - uses: actions/checkout@v4
-        with:
+        with: # checkout the base branch, where we run the script from
+          path: base
+      - uses: actions/checkout@v4
+        with: # checkout the merge commit, where the PR changes are
+          ref: refs/pull/${{ github.event.number }}/merge
+          path: merge
+          # we need full history
           fetch-depth: 0
-      - name: Run labeler script
+      - name: Run labeler script from base
         env:
           GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
           PR_NUMBER: ${{ github.event.number }}
           FAIL_IF_XL: '1'
-        run: ./devtools/scripts/github-set-pr-label.sh
+          MAIN_BRANCH: ${{ github.event.pull_request.base.ref }}
+        run: cd merge && ../base/devtools/scripts/github-set-pr-label.sh

alert/store.go

@@ -809,7 +809,7 @@ func (s *Store) Feedback(ctx context.Context, alertIDs []int) ([]Feedback, error
 		return nil, err
 	}
 
-	ids := make([]int32, len(alertIDs))
+	ids := make([]int32, 0, len(alertIDs))
 	for _, id := range alertIDs {
 		ids = append(ids, int32(id))
 	}

devtools/scripts/github-set-pr-label.sh

@@ -6,7 +6,8 @@ if [ -z "PR_NUMBER" ]; then
     exit 1
 fi
 
-LABEL=$(./devtools/scripts/git-diff-label-calc.sh --debug)
+MY_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
+LABEL=$("$MY_DIR/git-diff-label-calc.sh" --debug)
 
 # Remove any existing test/* labels
 for label in $(gh pr view "$PR_NUMBER" --json labels --jq '.labels[] | select(.name | startswith("size/")) | .name'); do