ui/policy: always use Dest API (#3867)

* remove dest conditionals from policy page * add missing name attr * fix step test * update remaining step tests * remove unused files/code * rename Chip -> ServiceChip * update favorites test * remove console.log * add checks after each add action * remove .only * update material select tests * add checks for webhook create --------- Co-authored-by: Forfold <[email protected]>
target · Jul 2, 2024 · 8ee27bd · 8ee27bd
1 parent 81edf64
commit 8ee27bd
Show file tree

Hide file tree

Showing 16 changed files with 192 additions and 910 deletions.
diff --git a/web/src/app/alerts/CreateAlertDialog/StepContent/CreateAlertConfirm.tsx b/web/src/app/alerts/CreateAlertDialog/StepContent/CreateAlertConfirm.tsx
@@ -1,7 +1,7 @@
 import React, { ReactNode } from 'react'
 import { Typography, Grid, Divider } from '@mui/material'
 import makeStyles from '@mui/styles/makeStyles'
-import { ServiceChip } from '../../../util/Chips'
+import { ServiceChip } from '../../../util/ServiceChip'
 import { FormField } from '../../../forms'
 import Markdown from '../../../util/Markdown'
 

diff --git a/web/src/app/alerts/CreateAlertDialog/StepContent/CreateAlertServiceSelect.tsx b/web/src/app/alerts/CreateAlertDialog/StepContent/CreateAlertServiceSelect.tsx
@@ -20,7 +20,7 @@ import makeStyles from '@mui/styles/makeStyles'
 import ServiceLabelFilterContainer from '../../../services/ServiceFilterContainer'
 import { Search as SearchIcon } from '@mui/icons-material'
 import { FavoriteIcon } from '../../../util/SetFavoriteButton'
-import { ServiceChip } from '../../../util/Chips'
+import { ServiceChip } from '../../../util/ServiceChip'
 import AddIcon from '@mui/icons-material/Add'
 import _ from 'lodash'
 import getServiceFilters from '../../../util/getServiceFilters'

diff --git a/web/src/app/escalation-policies/PolicyStepCreateDialog.tsx b/web/src/app/escalation-policies/PolicyStepCreateDialog.tsx
diff --git a/web/src/app/escalation-policies/PolicyStepEditDialog.tsx b/web/src/app/escalation-policies/PolicyStepEditDialog.tsx
diff --git a/web/src/app/escalation-policies/PolicyStepEditDialogDest.tsx b/web/src/app/escalation-policies/PolicyStepEditDialogDest.tsx
@@ -73,8 +73,7 @@ function PolicyStepEditDialogDest(
   // - actions field has it's own validation
   // - errors on existing actions are not handled specially, and just display in the dialog (i.e., duplicates)
   // - the delay field has no validation, and is automatically clamped to the min/max values by the backend
-  const [a, errs] = splitErrorsByPath(editStepStatus.error, [])
-  console.log(a, errs, editStepStatus.error)
+  const [, errs] = splitErrorsByPath(editStepStatus.error, [])
 
   return (
     <FormDialog