Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

label: add support for escalation policy, schedule, and rotation types #3429

Open
wants to merge 23 commits into
base: master
Choose a base branch
from

Conversation

mastercactapus
Copy link
Member

Description:
Adds label support for escalation policies, schedules, and rotations.

Which issue(s) this PR fixes:
Part of #3403

Out of Scope:

  • Searching by label for ep, schedules, rotations, will be done separately.

Describe any introduced user-facing changes:
N/A

Describe any introduced API changes:

  • EP, schedule, and rotation types now have a labels field, similar to services
  • create* for EP, schedule, and rotation now can pass in labels, similar to services
  • setting labels now supports EP, schedule, and rotations as a target type

@github-actions github-actions bot added the size/m label Nov 7, 2023
Copy link
Collaborator

@tony-tvu tony-tvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we be able to create labels for escalation policy, schedule, and rotations on this branch? Since serviceID can't be null, I'm getting an error when trying to create a label for anything other than service labels.
Screenshot 2023-11-08 at 3 54 21 PM
Screenshot 2023-11-08 at 3 58 56 PM

@mastercactapus
Copy link
Member Author

@tony-tvu oops, you're right; fixed in latest commit. You will need to make regendb though since it's a change in the migration

allending313
allending313 previously approved these changes Nov 22, 2023
allending313
allending313 previously approved these changes Nov 27, 2023
allending313
allending313 previously approved these changes Nov 27, 2023
@Forfold Forfold self-requested a review December 28, 2023 17:16
Forfold
Forfold previously approved these changes Dec 28, 2023
Copy link

stale bot commented Mar 17, 2024

This pull request has been automatically marked as stale because it has not had recent activity. Thank you for your contributions.

@stale stale bot added the stale This is inactive label Mar 17, 2024
@stale stale bot removed the stale This is inactive label Apr 15, 2024
Forfold
Forfold previously approved these changes Apr 16, 2024
Forfold
Forfold previously approved these changes May 2, 2024
Forfold
Forfold previously approved these changes May 14, 2024
Forfold
Forfold previously approved these changes May 14, 2024
allending313
allending313 previously approved these changes May 15, 2024
@Forfold Forfold dismissed stale reviews from allending313 and themself via 5737a0b July 3, 2024 17:51
Copy link
Contributor

@Forfold Forfold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

failed build deleted on CI, re-running to see failure

edit: looks like when editing a label, it is instead creating a new one on submit, resulting in the test failing because the page locator resolves to two elements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants