Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui/policy: always use Dest API #3867

Merged
merged 13 commits into from
May 15, 2024
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import React, { ReactNode } from 'react'
import { Typography, Grid, Divider } from '@mui/material'
import makeStyles from '@mui/styles/makeStyles'
import { ServiceChip } from '../../../util/Chips'
import { ServiceChip } from '../../../util/ServiceChip'
import { FormField } from '../../../forms'
import Markdown from '../../../util/Markdown'

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ import makeStyles from '@mui/styles/makeStyles'
import ServiceLabelFilterContainer from '../../../services/ServiceFilterContainer'
import { Search as SearchIcon } from '@mui/icons-material'
import { FavoriteIcon } from '../../../util/SetFavoriteButton'
import { ServiceChip } from '../../../util/Chips'
import { ServiceChip } from '../../../util/ServiceChip'
import AddIcon from '@mui/icons-material/Add'
import _ from 'lodash'
import getServiceFilters from '../../../util/getServiceFilters'
Expand Down
82 changes: 0 additions & 82 deletions web/src/app/escalation-policies/PolicyStepCreateDialog.tsx

This file was deleted.

69 changes: 0 additions & 69 deletions web/src/app/escalation-policies/PolicyStepEditDialog.tsx

This file was deleted.

3 changes: 1 addition & 2 deletions web/src/app/escalation-policies/PolicyStepEditDialogDest.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -73,8 +73,7 @@ function PolicyStepEditDialogDest(
// - actions field has it's own validation
// - errors on existing actions are not handled specially, and just display in the dialog (i.e., duplicates)
// - the delay field has no validation, and is automatically clamped to the min/max values by the backend
const [a, errs] = splitErrorsByPath(editStepStatus.error, [])
console.log(a, errs, editStepStatus.error)
const [, errs] = splitErrorsByPath(editStepStatus.error, [])

return (
<FormDialog
Expand Down
Loading
Loading