add smtp retries #4115
Merged
add smtp retries #4115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make checkto catch common errors. Fixed any that came up.Description:
remotemonitorshould retry sending emails to create alerts to avoid getting paged due to a temporary network outage or similar.Which issue(s) this PR fixes:
N/A - this is a small change to implement retrying SMTP send in
remotemonitoronlyOut of Scope:
Screenshots:
Describe any introduced user-facing changes:
Describe any introduced API changes:
For users of
goalert monitorcommand, an additional field is added to the TOML config to allow specifying a number of times to retry sending email when creating test alerts. The field is validated to ensure inputs are reasonable (in range 0-5).Additional Info: