notification/webhook: all webhooks are signed by a new set of signing keys #4225
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make check
to catch common errors. Fixed any that came up.Description:
This PR:
X-Webhook-Signature
, converting the raw binary signature to base64Which issue(s) this PR fixes:
Part of #4224
Out of Scope:
Screenshots:
Describe any introduced user-facing changes:
Users will notice a new
X-Webhook-Signature
header on any outgoing webhook.They will not be able to validate the webhook signature with just this PR as the public key will not have been exposed.
Describe any introduced API changes:
N/a
Additional Info: