Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the change
In an effort to improve the consistency of output from ScanQr the following changes are introduced:
Type
field which was confusing and impreciseData
field from string to list of stringsUpgrades related dependencies for ScanTranscode to fix failing tests in Python 3.11These upgrades are already in poetryEnabling inversion support adds some performance penalty. The following numbers are for an image with both a normal and an inverted QR code. Images with only one code will have a slightly lower penalty.
Describe testing procedures
Successfully built the container with included updated ScanQr tests. Confirmed correct event output from oneshot.
Sample output
Checklist