Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly define setuptools dependency #469

Merged
merged 2 commits into from
Aug 12, 2024
Merged

Explicitly define setuptools dependency #469

merged 2 commits into from
Aug 12, 2024

Conversation

skalupa
Copy link
Collaborator

@skalupa skalupa commented Aug 12, 2024

Describe the change
After updating the nightly build to migrate from docker compose v1 to v2, there was still a build issue when running the nightly Strelka build. This PR looks to correct this issue by explicitly defining the setuptools dependency as recommended in this thread in the Python Poetry project repo. Likely this issue has a root cause in the fact that we are using an older version of Poetry, which should be upgraded in the future.

Describe testing procedures
Tested with local docker build and confirmed that Git Action build worked successfully in this build.

Sample output
N/A

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of and tested my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@skalupa skalupa requested a review from phutelmyer August 12, 2024 16:48
@skalupa skalupa merged commit 5a5fc63 into master Aug 12, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants