Update test scripts for improved coverage and precision settings.

Signed-off-by: Sam Poyigi <[email protected]>
tastyigniter · Dec 28, 2024 · 5542761 · 5542761
1 parent 2b13403
commit 5542761
Show file tree

Hide file tree

Showing 53 changed files with 3,693 additions and 926 deletions.
diff --git a/composer.json b/composer.json
@@ -10,16 +10,16 @@
     }
   ],
   "require": {
-    "tastyigniter/core": "^v4.0@beta",
-    "tastyigniter/ti-ext-automation": "^v4.0@beta",
-    "tastyigniter/ti-ext-cart": "^v4.0@beta",
-    "tastyigniter/ti-ext-reservation": "^v4.0@beta"
+    "tastyigniter/core": "^v4.0@beta || ^v4.0@dev",
+    "tastyigniter/ti-ext-automation": "^v4.0@beta || ^v4.0@dev",
+    "tastyigniter/ti-ext-cart": "^v4.0@beta || ^v4.0@dev",
+    "tastyigniter/ti-ext-reservation": "^v4.0@beta || ^v4.0@dev"
   },
   "require-dev": {
     "laravel/pint": "^1.2",
     "larastan/larastan": "^2.4.0",
     "sampoyigi/testbench": "dev-main as 1.0",
-    "pestphp/pest-plugin-laravel": "^2.0",
+    "pestphp/pest-plugin-laravel": "^3.0",
     "igniterlabs/ti-ext-importexport": "v4.x-dev as 4.0"
   },
   "autoload": {
@@ -45,7 +45,7 @@
     }
   },
   "scripts": {
-    "test": "vendor/bin/pest",
+    "test": "vendor/bin/pest --coverage --exactly=100",
     "test-coverage": "vendor/bin/pest --coverage",
     "format": "vendor/bin/pint",
     "static": "vendor/bin/phpstan analyse --ansi --memory-limit 1056M"
@@ -58,5 +58,5 @@
     },
     "sort-packages": true
   },
-  "minimum-stability": "beta"
+  "minimum-stability": "dev"
 }
diff --git a/phpstan-baseline.neon b/phpstan-baseline.neon
@@ -56,79 +56,79 @@ parameters:
 			path: src/Classes/Location.php
 
 		-
-			message: "#^Call to an undefined method Igniter\\\\Local\\\\Contracts\\\\LocationInterface\\:\\:getSettings\\(\\)\\.$#"
-			count: 1
+			message: "#^Call to an undefined method Igniter\\\\Local\\\\Contracts\\\\LocationInterface\\:\\:getKey\\(\\)\\.$#"
+			count: 3
 			path: src/Classes/Location.php
 
 		-
-			message: "#^Call to an undefined method Igniter\\\\Local\\\\Contracts\\\\LocationInterface\\:\\:listDeliveryAreas\\(\\)\\.$#"
+			message: "#^Call to an undefined method Igniter\\\\Local\\\\Contracts\\\\LocationInterface\\:\\:getSettings\\(\\)\\.$#"
 			count: 1
 			path: src/Classes/Location.php
 
 		-
-			message: "#^Call to an undefined method Igniter\\\\Local\\\\Contracts\\\\LocationInterface\\:\\:searchOrDefaultDeliveryArea\\(\\)\\.$#"
+			message: "#^Call to an undefined method Igniter\\\\Local\\\\Contracts\\\\LocationInterface\\:\\:getSlugKeyName\\(\\)\\.$#"
 			count: 1
 			path: src/Classes/Location.php
 
 		-
-			message: "#^Call to an undefined method Igniter\\\\Local\\\\Contracts\\\\LocationInterface\\:\\:shouldAddLeadTime\\(\\)\\.$#"
+			message: "#^Call to an undefined method Igniter\\\\Local\\\\Contracts\\\\LocationInterface\\:\\:listDeliveryAreas\\(\\)\\.$#"
 			count: 1
 			path: src/Classes/Location.php
 
 		-
-			message: "#^Call to an undefined method Igniter\\\\Local\\\\Contracts\\\\LocationInterface\\:\\:getKey\\(\\)\\.$#"
-			count: 3
-			path: src/Classes/Manager.php
+			message: "#^Call to an undefined method Igniter\\\\Local\\\\Contracts\\\\LocationInterface\\:\\:newQuery\\(\\)\\.$#"
+			count: 1
+			path: src/Classes/Location.php
 
 		-
-			message: "#^Call to an undefined method Igniter\\\\Local\\\\Contracts\\\\LocationInterface\\:\\:getSlugKeyName\\(\\)\\.$#"
+			message: "#^Call to an undefined method Igniter\\\\Local\\\\Contracts\\\\LocationInterface\\:\\:newWorkingSchedule\\(\\)\\.$#"
 			count: 1
-			path: src/Classes/Manager.php
+			path: src/Classes/Location.php
 
 		-
-			message: "#^Call to an undefined method Igniter\\\\Local\\\\Contracts\\\\LocationInterface\\:\\:newQuery\\(\\)\\.$#"
+			message: "#^Call to an undefined method Igniter\\\\Local\\\\Contracts\\\\LocationInterface\\:\\:searchOrDefaultDeliveryArea\\(\\)\\.$#"
 			count: 1
-			path: src/Classes/Manager.php
+			path: src/Classes/Location.php
 
 		-
-			message: "#^Call to an undefined method Igniter\\\\Local\\\\Contracts\\\\LocationInterface\\:\\:newWorkingSchedule\\(\\)\\.$#"
+			message: "#^Call to an undefined method Igniter\\\\Local\\\\Contracts\\\\LocationInterface\\:\\:shouldAddLeadTime\\(\\)\\.$#"
 			count: 1
-			path: src/Classes/Manager.php
+			path: src/Classes/Location.php
 
 		-
 			message: "#^Call to an undefined method Illuminate\\\\Database\\\\Eloquent\\\\Builder\\:\\:IsEnabled\\(\\)\\.$#"
 			count: 1
-			path: src/Classes/Manager.php
+			path: src/Classes/Location.php
 
 		-
 			message: "#^Call to an undefined method Illuminate\\\\Database\\\\Query\\\\Builder\\:\\:selectDistance\\(\\)\\.$#"
 			count: 1
-			path: src/Classes/Manager.php
+			path: src/Classes/Location.php
 
 		-
 			message: "#^Call to an undefined method Illuminate\\\\Database\\\\Query\\\\Builder\\:\\:whereIsEnabled\\(\\)\\.$#"
 			count: 1
-			path: src/Classes/Manager.php
+			path: src/Classes/Location.php
 
 		-
 			message: "#^Call to an undefined method Illuminate\\\\Support\\\\Optional\\:\\:hasPermission\\(\\)\\.$#"
 			count: 1
-			path: src/Classes/Manager.php
+			path: src/Classes/Location.php
 
 		-
 			message: "#^Call to an undefined static method Igniter\\\\User\\\\Facades\\\\AdminAuth\\:\\:getUser\\(\\)\\.$#"
 			count: 1
-			path: src/Classes/Manager.php
+			path: src/Classes/Location.php
 
 		-
 			message: "#^Call to an undefined static method Igniter\\\\User\\\\Facades\\\\AdminAuth\\:\\:isSuperUser\\(\\)\\.$#"
 			count: 1
-			path: src/Classes/Manager.php
+			path: src/Classes/Location.php
 
 		-
 			message: "#^Call to an undefined static method Igniter\\\\User\\\\Facades\\\\AdminAuth\\:\\:user\\(\\)\\.$#"
 			count: 1
-			path: src/Classes/Manager.php
+			path: src/Classes/Location.php
 
 		-
 			message: "#^Call to an undefined method Illuminate\\\\Database\\\\Eloquent\\\\Model\\:\\:getWeekDaysOptions\\(\\)\\.$#"
@@ -200,6 +200,11 @@ parameters:
 			count: 1
 			path: src/Extension.php
 
+		-
+			message: "#^Call to an undefined static method Igniter\\\\Flame\\\\Support\\\\Facades\\\\Igniter\\:\\:runningInAdmin\\(\\)\\.$#"
+			count: 2
+			path: src/Extension.php
+
 		-
 			message: "#^Call to an undefined static method Igniter\\\\Local\\\\Facades\\\\Location\\:\\:updateNearbyArea\\(\\)\\.$#"
 			count: 1
@@ -286,17 +291,22 @@ parameters:
 			path: src/Http/Controllers/Reviews.php
 
 		-
-			message: "#^Call to an undefined static method Igniter\\\\Local\\\\Facades\\\\Location\\:\\:current\\(\\)\\.$#"
+			message: "#^Call to an undefined static method Igniter\\\\Flame\\\\Support\\\\Facades\\\\Igniter\\:\\:hasDatabase\\(\\)\\.$#"
 			count: 1
 			path: src/Http/Middleware/CheckLocation.php
 
 		-
-			message: "#^Call to an undefined static method Igniter\\\\Local\\\\Facades\\\\Location\\:\\:currentOrDefault\\(\\)\\.$#"
+			message: "#^Call to an undefined static method Igniter\\\\Flame\\\\Support\\\\Facades\\\\Igniter\\:\\:runningInAdmin\\(\\)\\.$#"
+			count: 2
+			path: src/Http/Middleware/CheckLocation.php
+
+		-
+			message: "#^Call to an undefined static method Igniter\\\\Local\\\\Facades\\\\Location\\:\\:current\\(\\)\\.$#"
 			count: 1
 			path: src/Http/Middleware/CheckLocation.php
 
 		-
-			message: "#^Call to an undefined static method Igniter\\\\Local\\\\Facades\\\\Location\\:\\:resetSession\\(\\)\\.$#"
+			message: "#^Call to an undefined static method Igniter\\\\Local\\\\Facades\\\\Location\\:\\:currentOrDefault\\(\\)\\.$#"
 			count: 1
 			path: src/Http/Middleware/CheckLocation.php
 
@@ -470,11 +480,6 @@ parameters:
 			count: 1
 			path: src/Models/Location.php
 
-		-
-			message: "#^Access to an undefined property Igniter\\\\Local\\\\Models\\\\Location\\:\\:\\$options\\.$#"
-			count: 1
-			path: src/Models/Location.php
-
 		-
 			message: "#^Access to an undefined property Igniter\\\\Local\\\\Models\\\\Location\\:\\:\\$permalink_slug\\.$#"
 			count: 1
@@ -545,11 +550,6 @@ parameters:
 			count: 1
 			path: src/Models/Location.php
 
-		-
-			message: "#^Method Igniter\\\\Local\\\\Models\\\\Location\\:\\:getCurrentTime\\(\\) should return Carbon\\\\Carbon but return statement is missing\\.$#"
-			count: 1
-			path: src/Models/Location.php
-
 		-
 			message: "#^Access to an undefined property Igniter\\\\Local\\\\Models\\\\LocationArea\\:\\:\\$boundaries\\.$#"
 			count: 1
@@ -562,7 +562,7 @@ parameters:
 
 		-
 			message: "#^Access to an undefined property Igniter\\\\Local\\\\Models\\\\LocationArea\\:\\:\\$location_id\\.$#"
-			count: 1
+			count: 2
 			path: src/Models/LocationArea.php
 
 		-
@@ -665,6 +665,11 @@ parameters:
 			count: 1
 			path: src/Models/Review.php
 
+		-
+			message: "#^Call to an undefined static method Igniter\\\\Flame\\\\Support\\\\Facades\\\\Igniter\\:\\:runningInAdmin\\(\\)\\.$#"
+			count: 1
+			path: src/Models/Review.php
+
 		-
 			message: "#^Call to an undefined static method Igniter\\\\Local\\\\Models\\\\Review\\:\\:whereReviewable\\(\\)\\.$#"
 			count: 1
@@ -745,11 +750,6 @@ parameters:
 			count: 1
 			path: src/Models/WorkingHour.php
 
-		-
-			message: "#^Call to an undefined static method Igniter\\\\Local\\\\Models\\\\WorkingHour\\:\\:where\\(\\)\\.$#"
-			count: 1
-			path: src/Models/WorkingHour.php
-
 		-
 			message: "#^Method Carbon\\\\Carbon\\:\\:addDay\\(\\) invoked with 1 parameter, 0 required\\.$#"
 			count: 1

diff --git a/src/AutomationRules/Conditions/ReviewCount.php b/src/AutomationRules/Conditions/ReviewCount.php
@@ -34,7 +34,7 @@ public function defineModelAttributes()
     public function getReviewCountAttribute($value, $object)
     {
         if (!$object instanceof Order && !$object instanceof Reservation) {
-            return false;
+            return 0;
         }
 
         return Review::query()->where([