-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: slur crowdsource feature #364
Conversation
Thanks @aatmanvaidya |
…into slur-crowdsource
…ttle-made#373) Builds the extension for firefox and chrome and adds a link to them under the PR comments section.
…into slur-crowdsource
|
GitGuardian id | Secret | Commit | Filename | |
---|---|---|---|---|
- | Username Password | 819728a | browser-extension/docker-compose.yml | View secret |
- | Username Password | bfbb14b | browser-extension/docker-compose.yml | View secret |
- | Username Password | 5170b76 | browser-extension/docker-compose.yml | View secret |
- | Username Password | 177ab3c | browser-extension/docker-compose.yml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
- support required for radiobutton group
Proposed Pending Improvements :
|
Describe the PR
This PR creates a new feature where Slurs can be crowdsourced by Uli users. This PR resolves #316 and #289.
A crowdsourced slur will have the following metadata
A user can Add, Edit, Update and Delete a Slur Word they created.
Steps to test the PR
npm install
http://localhost:3000 ws://localhost
to the manifest file and make sure you have adevelopment.env
file setup.localhost:8080
and see if the tables can be seen. If not do the migrations usingnpx sequelize db:migrate
. You should be able to see the two new tables "SLUR" and "CATEGORY".dist
folder in your desired browser and test the PR.Expected behaviour
A user can do the CRUD operations for a slur
Screenshots
Things to Check closely in a Code Review
api-server/index.js
file. I am no longer sending a 501 error in the GET request when there are no slurs found. I saw that when there were no slurs in the table, the GET request was sending an empty array.Check the CRUD API requests when called in frontend, I want to just make sure I am not giving away any user information that could be a potential security bug in the future.The multi-optioncategories
is being handled separately; this is causing aWarning: A component is changing a controlled input to be uncontrolled. This is likely caused by the value changing from a defined to undefined, which should not happen.
I need some help in fixing this warning.manifest.json
files.Potential Things to be added and Worked on
Better UI, this will come in shape as final requirements come inAdd transactions to PUT and DELETE requests.Add a loading bar when CRUD is happening on a Slur.Modify the delete and edit button to emoji symbolWhen there are no Slurs for a user, the Add button should be centered at the page below the text.test axios requests using JestAdd notifications when slur is created, edited and deleted.Add like a warning in the UI if the metadata isn't filled upAdd Slur
form, also make the link a Button. Also add pop-ups, if the data is not saved.sit with denny to fix the true false radio button issuem - THE FORM STATE IS NOT BEING UPDAETD CORRECTELYAsk denny about multiple select dropdown from sematic UI - https://react.semantic-ui.com/modules/dropdown/https://www.reddit.com/r/reactjs/comments/vtgbai/comparison_of_ui_libraries_for_react/
Ask about Tailwind UI - its pretty light - https://tailwind-elements.com/docs/standard/forms/select/Why isn't Grommet Multiple Select work?Add a red star to required questions.how do de-select a radio button option - especially for this - If, Appropriated, Is it by Community or Others?git commit -m "message" --no-verify
button cannot have red background color, why?Add Slur button coming for each slur card because of getSlurs.map() look into thisFix overflow slur issue in card js - fixed it by truncating textASK denny - the jest testing in npm is being written as npm run test-jest, do I move it to npm run testShould I truncate all the text or should I usewrap={true}
make sure slurs appear in descinding order in the slur index page