feat: db changed to postgres #619
Conversation
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 2074360 | Triggered | Generic Password | 3663a10 | browser-extension/docker-compose.yml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
|
Oh, nice! i was hoping the changes to be this minimal. |
| }, | ||
| test: { | ||
| username: "root", | ||
| password: null, | ||
| database: "uli_test", | ||
| host: "127.0.0.1", | ||
| dialect: "mysql", | ||
| dialect: "postgres", | ||
| }, | ||
| production: { | ||
| username: process.env.DB_USERNAME, | ||
| password: process.env.DB_PASSWORD, | ||
| database: "uli_prod_unicode", |
There was a problem hiding this comment.
Can this be picked up from the env too? process.env.DB_NAME perhaps?
There was a problem hiding this comment.
@eternaltyro hi, we have made that small change here - #620
is this the change you wanted?
This PR resolves issue #613.
Changes:
Other Changes in the
docker-composefile:node_modulesfolder. Previously, thenpm installcommand in the API_Server Dockerfile required dependencies to be installed locally. This change ensures dependencies are available without needing local installation.docker compose upcommand. By commenting out the linecommand: tail -f /dev/null, everything worked smoothly. This line is still commented out as it may have been causing issues by overriding the default startup command.