fix(macos): close menu when dropping NsMenuRef, close #129, #173 (#200)

tauri-apps · May 27, 2024 · 20ea54b · 20ea54b
1 parent 32a7e0a
commit 20ea54b
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/.changes/mac-close-menu-before-release.md b/.changes/mac-close-menu-before-release.md
@@ -0,0 +1,5 @@
+---
+"muda": patch
+---
+
+On macOS, close tray menu before removing it to prevent user click on a released menu item resulting in a crash.
diff --git a/src/platform_impl/macos/mod.rs b/src/platform_impl/macos/mod.rs
@@ -54,6 +54,7 @@ struct NsMenuRef(u32, id);
 impl Drop for NsMenuRef {
     fn drop(&mut self) {
         unsafe {
+            let _: () = msg_send![self.1, cancelTrackingWithoutAnimation];
             let _: () = msg_send![self.1, release];
         }
     }