Don't expose macOS implementation details in the public API #220
+66
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `show_context_menu_for_nsview` method previously used the `objc::runtime::Object` type, which means that the library's dependence on `objc` is exposed as part of the public API. Additionally, since the method is taking a raw pointer (and as such would be unsound if passing e.g. `ptr::dangling()`), I took the opportunity to also mark the method as `unsafe`. This is done in preparation for transitioning to `objc2`.
madsmtm
force-pushed
the
macos-make-impl-private
branch
from
92a6aaf
to
8f169cd
Compare
amrbashir
approved these changes
Sep 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
show_context_menu_for_nsviewmethod previously used theobjc::runtime::Objecttype, which means that the library's dependence onobjcis exposed as part of the public API.Additionally, since the method is taking a raw pointer (and as such is unsound because it allows passing e.g.
ptr::dangling()), I took the opportunity to also mark the method asunsafe.This is done in preparation for transitioning to
objc2, CC tauri-apps/wry#1239.