-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add RELEASING.md handbook #11026
Conversation
Package Changes Through c4408d9There are 5 changes which include @tauri-apps/api with prerelease, tauri-cli with prerelease, @tauri-apps/cli with prerelease, tauri with prerelease, tauri-utils with prerelease Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
|
||
- [ ] Double check that every package is pumped correctly and there is no accidental major or minor being released unless that is indeed the intention. | ||
- [ ] Make sure that there is no pending or unfinished [covector-version-or-publish.yml](./workflows/covector-version-or-publish.yml) workflow runs. | ||
- [ ] Sign the Version PR before merging as we require signed commits |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can the bot sign the commit so that we don't need to do this ourselves?
https://github.com/peter-evans/create-pull-request/releases/tag/v7.0.0 seems be able to do it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are not using peter-evans/create-pull-request but it is not impossible
ref: jbolda/covector#272
I wouldn't hold this PR on it though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Saying this is because we're using https://github.com/tauri-apps/create-pull-request which is a fork of it, and since I don't see any changes in the fork, I don't know why we did it to be honest
I wouldn't hold this PR on it though
Sure, I didn't know we need to do this before, just pointing it out
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Saying this is because we're using tauri-apps/create-pull-request which is a fork of it, and since I don't see any changes in the fork, I don't know why we did it to be honest
I believe it was for security reasons, cc @tweidinger @nothingismagick
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happened before I joined and it hasn't been maintained or updated by us, so I would rather delete our fork and use upstream with a version tag/commit hash.
Co-authored-by: Tony <[email protected]>
Co-authored-by: Tony <[email protected]>
Co-authored-by: Tony <[email protected]>
Co-authored-by: Tony <[email protected]>
Co-authored-by: Tony <[email protected]>
Co-authored-by: Tony <[email protected]>
Co-authored-by: Tony <[email protected]>
Co-authored-by: Tony <[email protected]>
Co-authored-by: Tony <[email protected]>
Co-authored-by: Tony <[email protected]>
Co-authored-by: Tony <[email protected]>
c4408d9
No description provided.