Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add RELEASING.md handbook #11026

Merged
merged 13 commits into from
Sep 17, 2024
Merged

docs: add RELEASING.md handbook #11026

merged 13 commits into from
Sep 17, 2024

Conversation

amrbashir
Copy link
Member

No description provided.

@amrbashir amrbashir requested a review from a team as a code owner September 16, 2024 14:25
Copy link
Contributor

github-actions bot commented Sep 16, 2024

Package Changes Through c4408d9

There are 5 changes which include @tauri-apps/api with prerelease, tauri-cli with prerelease, @tauri-apps/cli with prerelease, tauri with prerelease, tauri-utils with prerelease

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
@tauri-apps/api 2.0.0-rc.4 2.0.0-rc.5
tauri-utils 2.0.0-rc.11 2.0.0-rc.12
tauri-bundler 2.0.1-rc.12 2.0.1-rc.13
tauri-runtime 2.0.0-rc.11 2.0.0-rc.12
tauri-runtime-wry 2.0.0-rc.12 2.0.0-rc.13
tauri-codegen 2.0.0-rc.11 2.0.0-rc.12
tauri-macros 2.0.0-rc.10 2.0.0-rc.11
tauri-plugin 2.0.0-rc.11 2.0.0-rc.12
tauri-build 2.0.0-rc.11 2.0.0-rc.12
tauri 2.0.0-rc.14 2.0.0-rc.15
@tauri-apps/cli 2.0.0-rc.15 2.0.0-rc.16
tauri-cli 2.0.0-rc.15 2.0.0-rc.16

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector


- [ ] Double check that every package is pumped correctly and there is no accidental major or minor being released unless that is indeed the intention.
- [ ] Make sure that there is no pending or unfinished [covector-version-or-publish.yml](./workflows/covector-version-or-publish.yml) workflow runs.
- [ ] Sign the Version PR before merging as we require signed commits
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can the bot sign the commit so that we don't need to do this ourselves?

https://github.com/peter-evans/create-pull-request/releases/tag/v7.0.0 seems be able to do it

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are not using peter-evans/create-pull-request but it is not impossible

ref: jbolda/covector#272

I wouldn't hold this PR on it though

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Saying this is because we're using https://github.com/tauri-apps/create-pull-request which is a fork of it, and since I don't see any changes in the fork, I don't know why we did it to be honest

I wouldn't hold this PR on it though

Sure, I didn't know we need to do this before, just pointing it out

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Saying this is because we're using tauri-apps/create-pull-request which is a fork of it, and since I don't see any changes in the fork, I don't know why we did it to be honest

I believe it was for security reasons, cc @tweidinger @nothingismagick

Copy link
Contributor

@tweidinger tweidinger Sep 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happened before I joined and it hasn't been maintained or updated by us, so I would rather delete our fork and use upstream with a version tag/commit hash.

.github/RELEASING.md Outdated Show resolved Hide resolved
.github/RELEASING.md Outdated Show resolved Hide resolved
.github/RELEASING.md Outdated Show resolved Hide resolved
.github/RELEASING.md Outdated Show resolved Hide resolved
.github/RELEASING.md Outdated Show resolved Hide resolved
.github/RELEASING.md Outdated Show resolved Hide resolved
.github/RELEASING.md Outdated Show resolved Hide resolved
.github/RELEASING.md Outdated Show resolved Hide resolved
.github/RELEASING.md Outdated Show resolved Hide resolved
.github/RELEASING.md Outdated Show resolved Hide resolved
.github/RELEASING.md Outdated Show resolved Hide resolved
.github/RELEASING.md Outdated Show resolved Hide resolved
Legend-Master
Legend-Master previously approved these changes Sep 17, 2024
FabianLars
FabianLars previously approved these changes Sep 17, 2024
.github/RELEASING.md Outdated Show resolved Hide resolved
@lucasfernog lucasfernog merged commit 5ff0bbc into dev Sep 17, 2024
7 of 8 checks passed
@lucasfernog lucasfernog deleted the release-handbook branch September 17, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants