-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: enhance event system rust apis #7996
Conversation
So I keep going back and forth between two decisions about one final piece of this PR which is
Also since I have changed |
I think @chippers might help you decide since he designed most of these APIs :) |
I think this PR is ready to go, I have decided to keep |
Since tauri-apps#7996, `Window::emit` has been moved to `Manager::emit`, but `tauri::Manager` is imported into scope only for `cfg(desktop)`.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___
)Other information
The goal of this PR is to remove the
trigger
term from the APIs which I don't see very often and would prefer to ditch and stick tolisten
andemit
only.Changed
emit
to emit events to JS and Rust side which should be the default IMO but should we provide another set of APIs to target either JS or Rust?