-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ci): Fix bench job #8045
fix(ci): Fix bench job #8045
Conversation
9389e6a
to
8d3925d
Compare
Our benchmark CI is completely broken :( it runs forever. |
Well, that wasn't expected 🤷♂️ I'll look at it. |
bc1b310
to
f798933
Compare
@lucasfernog I've fixed the benchmarks, which were running forever because they are normally stopped by a Tauri command, and This time, I tested it in a GitHub fork ;-) I've also fixed some Clippy warnings, and I've added the package
If you want to make sure a future Tauri breakage will not make the benchmarks run forever as it did, I can add a timeout. Hyperfine does not support this (cf. sharkdp/hyperfine#106) but we can wrap the command by a |
Fixes
bench
CI job, which is failing ondev
branch (webkit2gtk-4.1
is not available forubuntu-20.04
).What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___
)Other information