Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): Fix bench job #8045

Merged
merged 5 commits into from
Oct 22, 2023
Merged

Conversation

olivierlemasle
Copy link
Contributor

@olivierlemasle olivierlemasle commented Oct 18, 2023

Fixes bench CI job, which is failing on dev branch (webkit2gtk-4.1 is not available for ubuntu-20.04).

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@lucasfernog
Copy link
Member

Our benchmark CI is completely broken :( it runs forever.

@olivierlemasle
Copy link
Contributor Author

Well, that wasn't expected 🤷‍♂️

I'll look at it.

@olivierlemasle olivierlemasle marked this pull request as ready for review October 21, 2023 17:43
@olivierlemasle
Copy link
Contributor Author

@lucasfernog I've fixed the benchmarks, which were running forever because they are normally stopped by a Tauri command, and window.__TAURI__.invoke was used, so the command was never invoked.

This time, I tested it in a GitHub fork ;-)

I've also fixed some Clippy warnings, and I've added the package at-spi2-core to remove these warnings (cf #4315):

AT-SPI: Error retrieving accessibility bus address: org.freedesktop.DBus.Error.ServiceUnknown: The name org.a11y.Bus was not provided by any .service files


If you want to make sure a future Tauri breakage will not make the benchmarks run forever as it did, I can add a timeout. Hyperfine does not support this (cf. sharkdp/hyperfine#106) but we can wrap the command by a timeout command.

@lucasfernog lucasfernog merged commit fec8943 into tauri-apps:dev Oct 22, 2023
4 checks passed
@olivierlemasle olivierlemasle deleted the fix-ci-bench branch October 22, 2023 16:26
ReactorScram added a commit to firezone/firezone that referenced this pull request Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🔎 In audit
Development

Successfully merging this pull request may close these issues.

2 participants