Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): merge user-defined plist with the iOS plist file #8200

Merged
merged 2 commits into from
Nov 14, 2023

Conversation

lucasfernog
Copy link
Member

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

Merge the src-tauri/Info.plist and src-tauri/Info.ios.plist files with the iOS project Info.plist file to allow extending the IPA configuration, similar to the macOS implementation.

Merge the src-tauri/Info.plist and src-tauri/Info.ios.plist files with the iOS project Info.plist file to allow extending the IPA configuration, similar to the macOS implementation.
@lucasfernog lucasfernog requested a review from a team as a code owner November 9, 2023 11:59
@lucasfernog
Copy link
Member Author

@FabianLars raised a possible issue with merging Info.plist for both macOS and iOS, but I couldn't think of anything really.. I feel like we could also read Info.macos.plist and let the user decide what's get shared to both platforms.

@lucasfernog lucasfernog merged commit 25e5f91 into dev Nov 14, 2023
15 checks passed
@lucasfernog lucasfernog deleted the feat/merge-ios-plist branch November 14, 2023 00:12
@FabianLars
Copy link
Member

even if there aren't any actual consequences (that'd crash something or something) they'd still pollute each other right? I mean, we're only talking about a few (k)bytes but v2 already has much larger binaries so every bit counts i guess?

but yeah, as long as there aren't any actual issues i don't really care ig

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants