Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Enter, Mouse and Leave events #161

Merged
merged 4 commits into from
May 14, 2024
Merged

Conversation

amrbashir
Copy link
Member

closes #123

@amrbashir
Copy link
Member Author

@pewsheen as always, can you take care of macOS part? thanks

@pewsheen
Copy link
Contributor

pewsheen commented May 14, 2024

@pewsheen as always, can you take care of macOS part? thanks

The left and right mouse up event is quite unreliable on macOS. It will be ignored when the menu poped up.

@amrbashir
Copy link
Member Author

thanks @pewsheen, LGTM

@amrbashir amrbashir merged commit 587292b into dev May 14, 2024
8 checks passed
@amrbashir amrbashir deleted the feat/enter-leave-events branch May 14, 2024 14:41
@nongyehong
Copy link

Ah, so how can I determine the position of my system icon, I think this hover mouse event can expand a lot of functions

@amrbashir
Copy link
Member Author

you can call icon.rect() to get the position and size of the icon at any given time, also all the events include the position of the cursor when that event was triggered.

@yume-chan
Copy link

I wonder why double left click support was removed?

amrbashir added a commit that referenced this pull request Aug 26, 2024
This was previously removed in #161 in [email protected]

closes #173
amrbashir added a commit that referenced this pull request Aug 26, 2024
This was previously removed in #161 in [email protected]

closes #173
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mouse-leave and mouse-enter events
4 participants