Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace libappindicator with ksni #201

Open
wants to merge 12 commits into
base: dev
Choose a base branch
from
Open

Replace libappindicator with ksni #201

wants to merge 12 commits into from

Conversation

dfaust
Copy link

@dfaust dfaust commented Nov 1, 2024

Using ksni and the xdg standard for tray icons on Linux unlocks missing functionality and new features (#104 and more), as well as unblocks a GTK4 migration (tauri-apps/webkit2gtk-rs#94).

  • Predefined menu items are not handled, except separator and about.
  • Shortcuts are ignored.

Companion PR for muda:
Export more internals so muda can be used in combination with ksni: tauri-apps/muda#239

Tauri issue:
[feat] Use ksni crate for tray icons on Linux: tauri-apps/tauri#11293

examples/tao.rs Outdated Show resolved Hide resolved
examples/tao.rs Outdated Show resolved Hide resolved
src/platform_impl/linux/mod.rs Outdated Show resolved Hide resolved
src/platform_impl/linux/mod.rs Show resolved Hide resolved
src/platform_impl/linux/mod.rs Show resolved Hide resolved
src/lib.rs Show resolved Hide resolved
@dfaust
Copy link
Author

dfaust commented Dec 31, 2024

@amrbashir @FabianLars How do we proceed from here? The tests fail because the PR depends on tauri-apps/muda#239.

@FabianLars
Copy link
Member

you can make tray-icon depend on the git version of muda for now

@amrbashir
Copy link
Member

Sorry for the delay, been a bit busy IRL, and also not sure if we want to have this in tauri v2, keep old implementation and add it in tauri v2 behind a feature flag or wait for v3

@FabianLars
Copy link
Member

if we make v3 only about switching from gtk3 to gtk4 (which imo we should) this change could wait for v3. If v3 takes ages i think it would be better to add it in v2 if that's not too much of a headache. I wouldn't put it behind a feature flag either way unless there's something missing compared to the libappindicator implementation that i don't see rn.

@dfaust
Copy link
Author

dfaust commented Dec 31, 2024

Alright. Then please keep me updated.
And I updated the muda dependency.

@amrbashir
Copy link
Member

I am actually leaning towards keeping the old implementation for now and adding this behind experimental feature flag (ksni) for both, tray-icon crate and tauri crate

@dfaust
Copy link
Author

dfaust commented Jan 8, 2025

I put the ksni stuff behind a feature flag linux-ksni (I also renamed the muda feature).

I also created a new PR for tauri (tauri-apps/tauri#12319).

And it seems the compiler has become more strict. I'm still fixing the windows issues. The macos issue I don't understand, though.

@FabianLars
Copy link
Member

the macos issue should be fixed by #220

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants