feat(windows): add WebViewBuilderExtWindows::with_scroll_bar_style
#1344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Package Changes Through 937353eThere are 1 changes which include wry with minor Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
|
Looks good! Just some tiny format issues that don't pass the CI. Also, we'll need you to sign your commits so that CI can merge this PR. |
I followed those exact instructions already, |
Use the CoreWebView2EnvironmentOptions API wrapper when creating a WebView2 environment on Windows, as opposed to using the ICoreWebView2EnvironmentOptions* COM interfaces. The wrapper exposes the interface methods with a more Rust-like API. It may be possible to do this with ICoreWebView2Controller as well, but I don't feel like experimenting with that right now. This is just an improvement I realised I could make while implementing tauri-apps#1339. Signed-off-by: Jamie Ridding <[email protected]>
Signed-off-by: Jamie Ridding <[email protected]>
Signed-off-by: Jamie Ridding <[email protected]>
I used the wrong change type for wry in 1344-with_scroll_bar_style. This commit upgrades the change type from a patch to a minor change. Signed-off-by: Jamie Ridding <[email protected]>
Signed-off-by: Jamie Ridding <[email protected]>
Themayu
force-pushed
the
feat/windows-add-scrollbar-style-option
branch
from
346b99c to
937353e
Compare
pewsheen
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1339.
Adds a
with_scroll_bar_styleoption to the webview builder on Windows, that can be used to opt into Fluent Overlay style scrollbars in the WebView2 environment. Also,wry::webview2::InnerWebView::create_environmentwas modified to directly make use of the COM wrapper API onCoreWebView2EnvironmentOptionsinstead of using the COM API interface; the implementations of those interfaces deferred to this wrapper anyway, and the wrapper exposes a more Rust-friendly API than the interfaces do.