Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add traffic light inset #1446

Merged
merged 7 commits into from
Jan 7, 2025
Merged

feat: Add traffic light inset #1446

merged 7 commits into from
Jan 7, 2025

Conversation

FabianLars
Copy link
Member

fixes #1056

I really wanted to fix this in tao or maybe in tauri but i just wasn't able to fix it in tao and in tauri it would have resulted in much more code (overwriting delegates and shit, see tauri-apps/tauri#4789

@FabianLars FabianLars requested a review from a team as a code owner January 6, 2025 17:00
Copy link
Contributor

github-actions bot commented Jan 6, 2025

Package Changes Through 17f5bb8

There are 1 changes which include wry with patch

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
wry 0.48.0 0.48.1

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

@FabianLars
Copy link
Member Author

i will open the tauri pr tomorrow

Copy link
Contributor

@pewsheen pewsheen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also the options seemed to conflict with with_decoration in Tao. I think we should mention that the app would panic if the title bar doesn't exist.

Another question is whether the setting works on multiple monitors with different DPI?
It looks good on different DPI

src/wkwebview/class/wry_web_view_parent.rs Outdated Show resolved Hide resolved
src/wkwebview/class/wry_web_view_parent.rs Show resolved Hide resolved
src/wkwebview/mod.rs Outdated Show resolved Hide resolved
@FabianLars
Copy link
Member Author

Also the options seemed to conflict with with_decoration in Tao. I think we should mention that the app would panic if the title bar doesn't exist.

Oh yes, absolutely. It requires a hidden title setting (which also means decorations are required). I meant to copy paste the electron docs document this but forgot about it because of another doc change.

@FabianLars FabianLars requested a review from pewsheen January 7, 2025 11:15
@pewsheen pewsheen merged commit cbbcccc into dev Jan 7, 2025
13 checks passed
@pewsheen pewsheen deleted the fix/traffic-light-inset branch January 7, 2025 14:28
@haasal
Copy link

haasal commented Jan 7, 2025

Hi, I am the original guy who tried to work on this. I have no idea what you did to fix this but I thank you deeply from my heart. I just couldn't look at this mess any longer without becoming anxious 😅

More importantly: I have lost track of this whole thing. Does my my kind of broken inset method still exist in Tao? If yes we should probably remove it right?

@FabianLars
Copy link
Member Author

I couldn't have done it without you 🫂

And no, we still need the Tao method. The method is also no broken (after all i use the very same impl here). It's still needed if the webview is injected via build_as_child (for multiwebview support for example). We probablyyy could overwrite this here as well, but imo windowing stuff should stay in the windowing library as much as possible.
Additionally, we still need the Tao implementation for what i fixed here as well, otherwise we would end up with the same flicker (but kinda in the opposite way). At least it did in my earlier tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Traffic light inset not working with wry webview
3 participants