-
-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation work; added platform-specific notes for nix #990
Open
pelasgus
wants to merge
8
commits into
tauri-apps:dev
Choose a base branch
from
pelasgus:dev
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+19
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…v env via nix for rust dev.
amrbashir
requested changes
Jul 24, 2023
Co-authored-by: Amr Bashir <[email protected]>
Only packages related to repository Co-authored-by: Amr Bashir <[email protected]>
Implemented all requested changes; pending approval. |
amrbashir
requested changes
Jul 26, 2023
- Added libappindicator-gtk3 & libayatana-indicator
Fixed libayatana
amrbashir
approved these changes
Jul 27, 2023
Oh looks like you didn't sign your first commit and I can't merge the PR unless all commits are signed. You need to setup commit signing, then you can sign past commit like this for example. |
@amrbashir just merge this anyway, your commits cannot be fully verified, its you and my original commit that are blocking merge. Please rectify, cheers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…v env via nix for rust dev.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
Other information