Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding an Interface for DI and CancellationToken for async methods #48

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Adding an Interface for DI and CancellationToken for async methods #48

wants to merge 4 commits into from

Conversation

kdcllc
Copy link

@kdcllc kdcllc commented Nov 18, 2020

  • Adding an interface for DI creation of the client not thru the new keyword
  • Adding Cancellation Tokens for all of the Async methods to be truly async

@kdcllc
Copy link
Author

kdcllc commented Dec 10, 2020

@ScottRudiger any chances for this PR to move forward?

@codymullins
Copy link
Contributor

Thanks for the PR, @kdcllc! We will check it out.

@kdcllc
- removed dependency from Bet.Extensions.Options
c6a73ab 
- added support for multiple clients registrations
- added two unit tests.
@kdcllc
Copy link
Author

kdcllc commented Dec 11, 2020

@codymullins I addressed all of the issues that you brought up. Let me know if this PR will do the job. I also at some point recommend enabling specifying ApiVersion via Options.

@kdcllc
Copy link
Author

kdcllc commented Feb 13, 2021

Any progress made on this?

@CLAassistant
Copy link

CLAassistant commented Nov 3, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@boylec boylec mentioned this pull request Nov 22, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codymullins codymullins codymullins left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kdcllc @codymullins @CLAassistant