TokenBucket: use 64bit if supported #179
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems travis does not understand uint64_t... To be continued. |
|
This should be done with templates and feature checks, right? |
Well in the end the 32bit and 64bit version do not work the same way as we do not need overflow checks and this max value trick. But some factorization could happen, yes... I tried the templating approach first and abandoned... |
Allows all elements such as ratedsource, ratedsplitter, ratedunqueue, and bandwidthratedunqueue to use > 4G rate. tokenbucket64 could have lass copy pasting, but I don't have time.
tbarbette
force-pushed
the
master
branch
2 times, most recently
from
b9c1853
to
b9f3521
Compare
|
Done in #395 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows all elements such as ratedsource, ratedsplitter, ratedunqueue,
and bandwidthratedunqueue to use > 4G rate.
tokenbucket64 could have lass copy pasting from tokenbucket, but I don't have time for this... I also changed the way it works a little. 32bit token buckets use overflow value as MAX. The 32bit value must therfore be scaled.
While with 64bit, I prefer to keep a reference to the max, and have easier and faster calculation.