Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editorial: remove Type() macro #3420

Merged
merged 2 commits into from
Sep 23, 2024
Merged

Editorial: remove Type() macro #3420

merged 2 commits into from
Sep 23, 2024

Conversation

ljharb
Copy link
Member

@ljharb ljharb commented Sep 6, 2024

Closes #3339.

@ljharb ljharb requested a review from a team September 6, 2024 05:08
@ljharb ljharb mentioned this pull request Sep 6, 2024
Closed
michaelficarra
michaelficarra reviewed Sep 6, 2024
View reviewed changes
spec.html Outdated Show resolved Hide resolved
ljharb added a commit to ljharb/ecma262 that referenced this pull request Sep 6, 2024
@ljharb
Editorial: ApplyStringOrNumericBinaryOperator: refactor into two ex…
38e5690 
…plicit tables (tc39#3420)
ljharb added a commit to ljharb/ecma262 that referenced this pull request Sep 6, 2024
@ljharb
Editorial: remove Type() AO-like macro (tc39#3420)
6d43c6d
michaelficarra
michaelficarra reviewed Sep 6, 2024
View reviewed changes
spec.html Outdated Show resolved Hide resolved
michaelficarra
michaelficarra approved these changes Sep 6, 2024
View reviewed changes
Copy link
Member

@michaelficarra michaelficarra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ljharb added a commit to ljharb/ecma262 that referenced this pull request Sep 6, 2024
@ljharb
Editorial: ApplyStringOrNumericBinaryOperator: refactor into two ex…
19a1b8f 
…plicit tables (tc39#3420)
ljharb added a commit to ljharb/ecma262 that referenced this pull request Sep 6, 2024
@ljharb
Editorial: remove Type() AO-like macro (tc39#3420)
442c106
ljharb added a commit to ljharb/ecma262 that referenced this pull request Sep 6, 2024
@ljharb
Editorial: remove Type() AO-like macro (tc39#3420)
c1ca241
ljharb added a commit to ljharb/ecma262 that referenced this pull request Sep 6, 2024
@ljharb
Editorial: ApplyStringOrNumericBinaryOperator: refactor into two ex…
882c659 
…plicit tables (tc39#3420)
ljharb added a commit to ljharb/ecma262 that referenced this pull request Sep 6, 2024
@ljharb
Editorial: remove Type() AO-like macro (tc39#3420)
6912218
@ljharb ljharb added the editor call to be discussed in the next editor call label Sep 10, 2024
syg
syg approved these changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@syg syg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm % oldid comment

spec.html Show resolved Hide resolved
@michaelficarra michaelficarra added ready to merge Editors believe this PR needs no further reviews, and is ready to land. and removed editor call to be discussed in the next editor call labels Sep 19, 2024
@michaelficarra michaelficarra mentioned this pull request Sep 19, 2024
Merged
@michaelficarra michaelficarra changed the title Editorial: remove Type() AO Editorial: remove Type() macro Sep 19, 2024
@ljharb ljharb merged commit fcd19b5 into tc39:main Sep 23, 2024
8 checks passed
@ljharb ljharb deleted the strip-types branch September 23, 2024 19:14
domenic pushed a commit to whatwg/html that referenced this pull request Oct 28, 2024
@michaelficarra
Editorial: replace uses of the Type macro with is-a tests
27f948a 
Follows tc39/ecma262#2874 and tc39/ecma262#3420.
@michaelficarra michaelficarra mentioned this pull request Oct 28, 2024
Merged
dizhang168 pushed a commit to dizhang168/html that referenced this pull request Oct 28, 2024
@michaelficarra @dizhang168
Editorial: replace uses of the Type macro with is-a tests
dce3ccc 
Follows tc39/ecma262#2874 and tc39/ecma262#3420.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelficarra michaelficarra michaelficarra approved these changes

@syg syg syg approved these changes

Assignees
No one assigned
Labels
editorial change ready to merge Editors believe this PR needs no further reviews, and is ready to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ljharb @syg @michaelficarra