Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add additional test cases for RegExp modifiers #4321

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add additional test cases for RegExp modifiers #4321

wants to merge 3 commits into from
+578 −6

Conversation

graphemecluster
Copy link

This is motivated by a bug discovered in both V8 and SpiderMonkey.
Follow up of #3960.

@graphemecluster graphemecluster requested a review from a team as a code owner November 10, 2024 22:28
@graphemecluster
Copy link
Author

CC @rbuckton and @JLHwung (who pushed me to report this bug to the engines).

graphemecluster
graphemecluster commented Nov 10, 2024
View reviewed changes
test/built-ins/RegExp/regexp-modifiers/nesting-remove-ignoreCase-within-add-ignoreCase.js
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is originally identical to nesting-add-ignoreCase-within-remove-ignoreCase.js, which is probably unintended.

JLHwung
JLHwung approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@JLHwung JLHwung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for providing new tests.

Ms2ger
Ms2ger approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@Ms2ger Ms2ger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JLHwung JLHwung JLHwung approved these changes

@Ms2ger Ms2ger Ms2ger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@graphemecluster @Ms2ger @JLHwung